Add M365CalendarMeetNow to EventActionSource enum#3075
Open
IoanaDudas wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a missing EventActionSource enum member so callers (e.g., Teams-side code) can use a type-safe enum value instead of the raw "m365_calendar_meet_now" string, aligning with the existing cross-repo contract described in the PR metadata.
Changes:
- Extend
EventActionSourcewithM365CalendarMeetNow = 'm365_calendar_meet_now'. - Add a beachball/change file to record the API surface update for
@microsoft/teams-js.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/teams-js/src/public/meeting/meeting.ts | Adds M365CalendarMeetNow to EventActionSource with matching string literal contract value. |
| change/@microsoft-teams-js-3b3bfc88-8bb4-41a4-b3f2-893ff39a085a.json | Records the change as a minor bump with a short changelog entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Backing issue: #3076 |
Add the `M365CalendarMeetNow = 'm365_calendar_meet_now'` member to the `EventActionSource` enum so Teams-side code can reference the enum member instead of a raw string literal. The OWA M365/Monarch calendar "Meet Now" start action already sends this source string, which the Teams host maps to create_meetup logging. Type-correctness follow-up only; no behavioral change. Teams bug 4507219, OWA PR #248961 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
IoanaDudas
force-pushed
the
user/idudas/add-meetnow-eventactionsource
branch
from
c522fbe to
3590023
Compare
Leah-Xia-Microsoft
approved these changes
Jul 2, 2026
Author
@microsoft-github-policy-service agree company="Microsoft" |
vhuseinova-msft
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
EventActionSource.M365CalendarMeetNow = 'm365_calendar_meet_now'so Teams-side code can reference the enum member instead of a raw string literal.This is a type-correctness-only follow-up — no behavioral change. The OWA M365/Monarch calendar "Meet Now → Start" action already sends
source: "m365_calendar_meet_now"tomeeting.joinMeeting, teams-js forwards the source as-is, and the Teams host already maps the literal string toisAdhoc: true→create_meetuplogging. This change simply completes the enum so the only M365-calendar source OWA sends that wasn't a member now is one.The string value
m365_calendar_meet_nowis the locked cross-repo contract (OWA sends it, Teams host matches it) and is byte-for-byte unchanged.Context: Teams bug 4507219, OWA PR #248961.
A beachball change file (minor) is included.