fix: sync accepted assets and fix activity feed issues #740 #741 #742 #743 - #830
Merged
OlaGreat merged 1 commit intoJul 23, 2026
Conversation
- Fix OlaGreat#740: Sync accepted asset quickpick toggles to setAssets() instead of only form.acceptedAssets. The API now receives the correct asset list. - Fix OlaGreat#741: Replace tx.senderAddress with tx.supporterAddress in activity-feed.tsx to match backend API response. - Fix OlaGreat#742: Use stellarExpertUrl() helper and correct network check (PUBLIC vs MAINNET) for Stellar Expert links. - Fix OlaGreat#743: Import API_BASE_URL from config instead of defining it locally to prevent config drift.
|
@Akanimoh12 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Lighthouse Report 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four frontend issues affecting profile creation and activity feed display:
setAssets), ensuring the profile is created with user-selected assets instead of always defaulting to XLM.tx.supporterAddress(correct field) instead oftx.senderAddress, properly displaying supporter identifiers.stellarExpertUrl()helper and correct network check (PUBLIC vs MAINNET) instead of hardcoding the URL.API_BASE_URLconstant and imported from@/lib/configto prevent config drift.Test plan
Closes