Build bounded Detail decode and cache core - #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AssetSourceIdentity.has_stable_revisionand worker-side stat repair. Legacy identities bypass both reusable memory and disk caches.bytesobject.Review remediation
Addresses #890 findings 7 and 9, plus the RAW intermediate-memory portion of finding 8. PlayerView-wide surface retention and Edit/Library lifecycle remain intentionally scoped to the later Detail/Edit/Library replacement PR.
Validation
compileall, workflow YAML parse, andgit diff --check: passed.bytes, asynchronous disk-hit checksum, 100-write batched pruning, source replacement invalidation, stat-failure bypass, and RAW budget fallback.Split context
Replacement PR 3 for draft #890. Depends only on merged #891 and #892. The modules are kept independent of Edit and Live Photo UI lifecycle so those behaviors can be reviewed and rolled back separately.