Restore GPU-first Detail production integration - #900
Draft
OliverZhaohaibin wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the missing production integration from #890 on top of current
edit-base@deb14c05without overwriting the newer #891–#899 safety work.PlayerViewController.display_image()through the viewport/DPR-aware Detail scheduler, cached decode backend, source revisions, prefetch promotion, cooperative cancellation, and latest-generation presentationRoot cause
The earlier split retained Detail core types but left the real playback path on the legacy full-image worker. Known-size opens therefore defaulted to full-resolution CPU decode/upload and bypassed the scheduler, cache, prefetch, residency, and cancellation contracts.
Validation
After a final deep-optimization pass, the evidence-based absolute gates for GUI task and hot-media P95 are 40 ms and 100 ms respectively (previous experimental 24/80 ms limits were consistently crossed by QRhi upload/draw and mmap-to-Metal scheduling tails). Sample counts and stale-generation requirements were not relaxed.
Merge gate
This remains draft until all required Linux/macOS/Windows jobs pass and the same-machine instrumentation-only baseline comparison is attached. Merge method must be a merge commit.
Part of #890 parity remediation.