-
Notifications
You must be signed in to change notification settings - Fork 2
feat: modular architecture refactoring with 95% test coverage #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9df64df
docs: add modular refactor specification and update constitution v1.0.1
amargiovanni 5d7be6c
i18n
amargiovanni 948d37f
feat: implement modular architecture refactoring
amargiovanni 08f20e1
feat: add interactive prompts for CLI options
amargiovanni a45b27f
fix: timezone-aware datetime comparison and improve banner colors
amargiovanni 37e4f9c
docs: add screenshots to README
amargiovanni 5e6cacd
ci: add GitHub Actions workflow for tests
amargiovanni 04f3503
test: add comprehensive unit tests for 80% coverage
amargiovanni faa54d1
test: achieve 95% coverage with 308 tests
amargiovanni 6096fcb
docs(readme): add comprehensive contributing guidelines
amargiovanni 4e5fd15
ci: align coverage threshold with documented goal (95%)
amargiovanni 3bea732
fix(docs): correct malformed CLAUDE.md commands section
amargiovanni 0d4681b
fix(api): handle timeout correctly via URLError wrapper
amargiovanni 9a7c638
fix(analyzers): filter PRs by updated_at instead of created_at
amargiovanni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| name: Tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, 001-modular-refactor] | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ['3.9', '3.10', '3.11', '3.12'] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements-dev.txt | ||
| pip install -r requirements.txt | ||
|
|
||
| - name: Run linter | ||
| run: | | ||
| ruff check src/github_analyzer/ | ||
|
|
||
| - name: Run tests | ||
| run: | | ||
| pytest tests/ -v --tb=short | ||
|
|
||
| - name: Run tests with coverage | ||
| run: | | ||
| pytest tests/ --cov=src/github_analyzer --cov-report=xml --cov-report=term-missing | ||
|
|
||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v4 | ||
| if: matrix.python-version == '3.11' | ||
| with: | ||
| files: ./coverage.xml | ||
| fail_ci_if_error: false | ||
|
|
||
| test-stdlib-only: | ||
| name: Test without requests (stdlib only) | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python 3.11 | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.11' | ||
|
|
||
| - name: Install test dependencies only | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install pytest pytest-cov | ||
|
|
||
| - name: Run tests without requests | ||
| run: | | ||
| pytest tests/ -v --tb=short |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,56 @@ | ||
| # OS files | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Python | ||
| __pycache__/ | ||
| *.py[cod] | ||
| *$py.class | ||
| *.so | ||
| .Python | ||
| build/ | ||
| develop-eggs/ | ||
| dist/ | ||
| downloads/ | ||
| eggs/ | ||
| .eggs/ | ||
| lib/ | ||
| lib64/ | ||
| parts/ | ||
| sdist/ | ||
| var/ | ||
| wheels/ | ||
| *.egg-info/ | ||
| .installed.cfg | ||
| *.egg | ||
|
|
||
| # Virtual environments | ||
| .venv/ | ||
| venv/ | ||
| ENV/ | ||
| env/ | ||
|
|
||
| # Testing | ||
| .pytest_cache/ | ||
| .coverage | ||
| htmlcov/ | ||
| .tox/ | ||
| .nox/ | ||
| coverage.xml | ||
| *.cover | ||
| *.py,cover | ||
|
|
||
| # IDE | ||
| .idea/ | ||
| .vscode/ | ||
| *.swp | ||
| *.swo | ||
| *~ | ||
|
|
||
| # Environment | ||
| .env | ||
| .env.local | ||
| *.env | ||
|
|
||
| # Project specific | ||
| github_export/*.csv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,29 @@ | ||||||
| # github_analyzer Development Guidelines | ||||||
|
|
||||||
| Auto-generated from all feature plans. Last updated: 2025-11-28 | ||||||
|
|
||||||
| ## Active Technologies | ||||||
|
|
||||||
| - Python 3.9+ (as per constitution, leveraging type hints) + Standard library only (urllib, json, csv, os, re); optional: requests (001-modular-refactor) | ||||||
|
|
||||||
| ## Project Structure | ||||||
|
|
||||||
| ```text | ||||||
| src/ | ||||||
| tests/ | ||||||
| ``` | ||||||
|
|
||||||
| ## Commands | ||||||
|
|
||||||
| cd src [ONLY COMMANDS FOR ACTIVE TECHNOLOGIES][ONLY COMMANDS FOR ACTIVE TECHNOLOGIES] pytest [ONLY COMMANDS FOR ACTIVE TECHNOLOGIES][ONLY COMMANDS FOR ACTIVE TECHNOLOGIES] ruff check . | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This command appears to be malformed. The
Suggested change
|
||||||
|
|
||||||
| ## Code Style | ||||||
|
|
||||||
| Python 3.9+ (as per constitution, leveraging type hints): Follow standard conventions | ||||||
|
|
||||||
| ## Recent Changes | ||||||
|
|
||||||
| - 001-modular-refactor: Added Python 3.9+ (as per constitution, leveraging type hints) + Standard library only (urllib, json, csv, os, re); optional: requests | ||||||
|
|
||||||
| <!-- MANUAL ADDITIONS START --> | ||||||
| <!-- MANUAL ADDITIONS END --> | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
Commandssection contains unresolved placeholders[ONLY COMMANDS FOR ACTIVE TECHNOLOGIES], which makes the example command invalid and confusing. This should be corrected to show a valid sequence of commands.