fix: remove undocumented fields from trip-details stopTimes schema

[3rabiii]

Description

This PR addresses by removing extra fields from the trip-details response that were not defined in the wiki spec, reducing payload noise and strictly adhering to the API contract.

Changes Included:

• Cleaned StopTime Model: Removed DropOffType and PickupType from the base StopTime struct in internal/models/stop_times.go to match the trip-details spec.
• Preserved Block Endpoint Contract: Since the block endpoint does require these fields in its spec, I introduced a new BlockStopTimeData struct in internal/models/block.go. This wrapper embeds the clean StopTime and appends the necessary drop-off/pickup types.
• Handler Updates: Updated block_handler.go to construct the response using the new BlockStopTimeData wrapper, isolating the schemas without duplicating core logic.
• Test Updates: Cleaned up stop_times_test.go to reflect the removed fields.

Fixes: #1057

Summary by CodeRabbit

Release Notes

• Refactor
  • Reorganized internal data model for block stop timing information to improve code structure and better separate scheduling attributes related to pickup and drop-off operations.

[coderabbitai]

📝 Walkthrough

Walkthrough

dropOffType and pickupType are removed from StopTime and relocated into a new BlockStopTimeData struct that wraps StopTime. BlockStopTime gains BlockSequence and DistanceAlongBlock fields and changes its StopTime field type to BlockStopTimeData. The block handler and StopTime test are updated accordingly.

Changes

BlockStopTime data model refactor

Layer / File(s)	Summary
StopTime and BlockStopTime struct changes internal/models/stop_times.go, internal/models/block.go	DropOffType and PickupType removed from StopTime; BlockStopTime gains BlockSequence int and DistanceAlongBlock float64 and changes its StopTime field type from StopTime to the new BlockStopTimeData; BlockStopTimeData embeds StopTime and adds DropOffType and PickupType.
Block handler construction and StopTime test update internal/restapi/block_handler.go, internal/models/stop_times_test.go	transformBlockToEntry nests ArrivalTime, DepartureTime, and StopID inside models.StopTime{} within models.BlockStopTimeData{}, with DropOffType and PickupType set alongside. TestStopTimeJSON removes those two field initializations from the StopTime literal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• trip-details: stopTimes contains extra fields dropOffType and pickupType not in spec #1057: This PR directly implements the fix described in the issue — removing dropOffType and pickupType from StopTime and relocating them to a new block-specific BlockStopTimeData struct to achieve specification compliance.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: removing undocumented fields (DropOffType and PickupType) from the StopTime schema to achieve API compliance.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud