Pass through per-trip route_id, headsign, start_date, start_time instead of gating on active trip#466
Open
KTibow wants to merge 2 commits into
Open
Pass through per-trip route_id, headsign, start_date, start_time instead of gating on active trip#466KTibow wants to merge 2 commits into
KTibow wants to merge 2 commits into
Conversation
…ead of gating on active trip route_id, headsign, start_date, start_time, and schedule_relationship were only set for the active trip. getScheduleForTrip() already fetched TripDetailsBean containing this data for every trip — it was just never used. This change uses the per-trip data for all trips on the block. The old comment 'we only know route if we are on activeTrip, the block may interline!' was incorrect — each trip has its own route in the static GTFS schedule, and getTripDetailsForTrip() returns it.
|
|
📝 WalkthroughWalkthroughTripUpdatesForAgencyAction’s timepoint-driven update flow now fetches full trip details per trip, uses those details to populate TripDescriptor fields, and derives the stop-time schedule from the returned trip details while keeping delay assignment limited to the active trip. ChangesTrip Updates Timepoint Detail Fetch
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Once again, not signing the CLA because it needs to be updated to use a custom gist instead of the SAP default |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@onebusaway-api-webapp/src/main/java/org/onebusaway/api/actions/api/gtfs_realtime/TripUpdatesForAgencyAction.java`:
- Around line 179-183: The start_date and start_time values in
TripUpdatesForAgencyAction are still derived from tripStatus.getServiceDate(),
which can cause downstream trips to inherit the active trip’s service day.
Update the TripUpdatesForAgencyAction logic around tripDesc.setStartDate,
tripDesc.setStartTime, and the tripDetails.getStatus() check to use the per-trip
service date/status when available, and skip setting a synthetic midnight
start_time when per-trip status is missing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e42e41fc-ee72-469f-9405-90d2e92a973a
📒 Files selected for processing (1)
onebusaway-api-webapp/src/main/java/org/onebusaway/api/actions/api/gtfs_realtime/TripUpdatesForAgencyAction.java
… is null The start_date and start_time fields were still derived from tripStatus.getServiceDate() (the active trip's service date). This caused downstream trips on the same block to inherit the active trip's service date, which was incorrect. Now using tripDetails.getServiceDate() for per-trip accuracy. Also skips setting a synthetic midnight start_time when tripDetails.getStatus() is null, instead of emitting a potentially misleading value.
KTibow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
route_id, headsign, start_date, start_time, and schedule_relationship were only set for the active trip. We already fetch TripDetailsBean containing this data for every trip — we just never use it. This change uses the per-trip data for all trips on the block.
The old comment "we only know route if we are on activeTrip, the block may interline!" was incorrect — each trip has its own route in the static GTFS schedule, and getTripDetailsForTrip() returns it.
Disclosure: Generated by DeepSeek V4 Pro with CI verification
Summary by CodeRabbit