Actually shorten the share escape's bar title in Arabic - #1407
Actually shorten the share escape's bar title in Arabic#1407diveshpatil9104 wants to merge 1 commit into
Conversation
It was 17 chars against the full phrase's 15, so ar was the one locale left worse off.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe Arabic localization now uses the shorter label “على أي حال” for sharing trips without a destination. ChangesArabic share label
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the visible Arabic share label to a shorter equivalent while retaining the full accessibility label. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Actually shorten the share escape's bar title in Arabic
Description
Follow-up from #1362, which Aaron raised on merge:
"مشاركة على أي حال"is 17 characters against the full phrase's 15. So Arabic was the one locale where the short title was longer than the thing it exists to replace, and the key's own comment was false for it.Now
"على أي حال"— 10 characters. Same fix pt-BR and es got in #1362: drop the verb, keep the "anyway" sense. The bar sits beside Cancel and the accessibility label still carries the full phrase.Summary by CodeRabbit