Skip to content

Actually shorten the share escape's bar title in Arabic - #1407

Open
diveshpatil9104 wants to merge 1 commit into
OneBusAway:mainfrom
diveshpatil9104:fix/1348-arabic-bar-button-length
Open

Actually shorten the share escape's bar title in Arabic#1407
diveshpatil9104 wants to merge 1 commit into
OneBusAway:mainfrom
diveshpatil9104:fix/1348-arabic-bar-button-length

Conversation

@diveshpatil9104

@diveshpatil9104 diveshpatil9104 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Actually shorten the share escape's bar title in Arabic

Description

Follow-up from #1362, which Aaron raised on merge:

in ar the "short" title is actually slightly wider than the full phrase it
replaces, so that locale gains a translation marginally worse than the one it
had. It just makes the "used where the full phrase will not fit" comment untrue
for that one locale.

"مشاركة على أي حال" is 17 characters against the full phrase's 15. So Arabic was the one locale where the short title was longer than the thing it exists to replace, and the key's own comment was false for it.

Now "على أي حال" — 10 characters. Same fix pt-BR and es got in #1362: drop the verb, keep the "anyway" sense. The bar sits beside Cancel and the accessibility label still carries the full phrase.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Arabic share button label for trips without a destination to use clearer, more concise wording.

It was 17 chars against the full phrase's 15, so ar was the one locale left worse off.
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: beed2c74-4fc9-4df2-8301-e1c65d38d854

📥 Commits

Reviewing files that changed from the base of the PR and between fd41dba and 4ad7568.

📒 Files selected for processing (1)
  • OBAKit/Strings/ar.lproj/Localizable.strings

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Arabic localization now uses the shorter label “على أي حال” for sharing trips without a destination.

Changes

Arabic share label

Layer / File(s) Summary
Update Arabic share label
OBAKit/Strings/ar.lproj/Localizable.strings
Changes destination_stop_picker.share_without_destination_bar_button to “على أي حال”.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4ad75

This updates the visible Arabic share label to a shorter equivalent while retaining the full accessibility label. No current merge-blocking risk is identified.

Suggested reviewers: aaronbrethorst, mosliem, borisserz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: shortening the Arabic share escape bar title.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant