Scope the simulator-UDID note to the commands that actually need one - #1410
Scope the simulator-UDID note to the commands that actually need one#1410diveshpatil9104 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe ChangesSimulator command guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Command guidance now distinguishes simulator-dependent build commands from linting, documentation, versioning, and help commands. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Follow-up from #1307, which Aaron raised on merge:
Checked each:
scripts/swiftlint.shandscripts/versionhave no simulator reference at all, andscripts/docsbuilds for-destination 'generic/platform=iOS'— a generic destination, not a device.Phrased as a list rather than a rule with exceptions. The failure this line invites is an agent resolving a UDID before running
swiftlint; "every command that touches a simulator" still leaves it to guess which those are, so the line now names both sides.Docs only.
Summary by CodeRabbit