docs(skill): 提交 zzz-od-dev-* skill 并采纳 superpowers 流程方法论 - #2438
Merged
Conversation
- 3 个 dev skill 重命名为 zzz-od-dev-* 并提交(此前 gitignore 等待团队决定) - 团队统一采用 superpowers 作开发流程方法论,dev skill 为项目特定补充 - .claude/skills/ 链接 symlink->junction(免管理员,对齐文档推荐) - 同步 ai_coding.md/quickstart.md/harness/README.md(skill 清单+superpowers 定位) Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: glm-5.2 <noreply@bigmodel.cn>
Contributor
📝 WalkthroughWalkthrough本 PR 新增三个开发类 skill 目录(zzz-od-dev-deciding-a-fix、zzz-od-dev-pr-finishing、zzz-od-dev-skill-guide),各含 SKILL.md 与 design.md 文档;移除 .gitignore 对相应目录的忽略规则;并更新 harness/setup 文档以反映 junction 加载方式与 superpowers 流程说明。 ChangesDev Skill 文档新增与项目文档同步
Estimated code review effort: 2 (Simple) | ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/develop/setup/ai_coding.md (1)
98-100: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win收紧第 ② 层的落点描述。
这里把
.claude/skills/<name>/写成“可提交”的项目级目录，但本仓库当前的约定是：dev skill 源放在根skills/<name>/，.claude/skills/只做本地 junction。现在这段又把根skills/写成单一源，读者很容易误解 ② 才是推荐提交点。建议把 ② 改成“本地/不提交”的工具私有目录，或明确这是通用示例，不是本仓库的推荐路径。Also applies to: 104-113
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/develop/setup/ai_coding.md` around lines 98 - 100, 收紧“② 工具项目级”的落点描述，避免把 .claude/skills/<name>/ 误写成本仓库推荐的可提交目录；请在该段中明确 .claude/skills/ 仅作为 Claude Code 的本地/junction 位置，真正的提交源仍应指向根目录 skills/<name>/，并调整第 ② 与第 ③ 层的文案以保持一致，防止读者误解推荐路径。
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/develop/setup/ai_coding.md`:
- Around line 98-100: 收紧“② 工具项目级”的落点描述，避免把 .claude/skills/<name>/
误写成本仓库推荐的可提交目录；请在该段中明确 .claude/skills/ 仅作为 Claude Code 的本地/junction
位置，真正的提交源仍应指向根目录 skills/<name>/，并调整第 ② 与第 ③ 层的文案以保持一致，防止读者误解推荐路径。
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fbc3d316-94a8-47b7-ab28-8740960dcba7
📒 Files selected for processing (10)
.gitignoredocs/develop/harness/README.mddocs/develop/setup/ai_coding.mddocs/develop/setup/quickstart.mdskills/zzz-od-dev-deciding-a-fix/SKILL.mdskills/zzz-od-dev-deciding-a-fix/design.mdskills/zzz-od-dev-pr-finishing/SKILL.mdskills/zzz-od-dev-pr-finishing/design.mdskills/zzz-od-dev-skill-guide/SKILL.mdskills/zzz-od-dev-skill-guide/design.md
💤 Files with no reviewable changes (1)
- .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
团队已形成共识统一采用 superpowers。此前 3 个 dev skill(
dev-pr-finishing/dev-deciding-a-fix/dev-skill-guide)在.gitignore里标注「暂不提交,等团队 superpowers 统一采用的决定」,现解锁提交。改动
1. dev skill 提交 + 命名规范落地
zzz-od-dev-*(符合ai_coding.md命名规范)并提交:zzz-od-dev-pr-finishing— PR 收尾(适配 CodeRabbit)zzz-od-dev-deciding-a-fix— 修复决策框架zzz-od-dev-skill-guide— 项目 skill 写作硬规范SKILL.md(name 字段)+design.md(旧名/路径/「待决」状态段)2. superpowers 定位(主干 vs 补充)
zzz-od-dev-*为叠加其上的项目特定补充,非替代3. 文档同步
ai_coding.md:加「推荐安装 superpowers」段 + 命名表(开发类/历史遗留)+ 现状段重写quickstart.md:Skills 段补全harness/README.md:skill 清单 4→7 + 方向 A 补 superpowers4. 其他
.gitignore:删 dev- 旧名忽略.claude/skills/:symlink → junction(mklink /J,免管理员,对齐文档推荐)说明
agent-auto-battle-config/agent-definition/new-config/zzz-one-dragon-player)保持原名不动,迁移价值待评估.claude/gitignore),每人本地建🤖 Generated with Claude Code
Summary by CodeRabbit