Skip to content

test(charge_plan): 覆盖特训目标动态计划 - #46

Open
pumpkinperson996 wants to merge 2 commits into
OneDragon-Anything:mainfrom
pumpkinperson996:codex/issue-2616
Open

test(charge_plan): 覆盖特训目标动态计划#46
pumpkinperson996 wants to merge 2 commits into
OneDragon-Anything:mainfrom
pumpkinperson996:codex/issue-2616

Conversation

@pumpkinperson996

@pumpkinperson996 pumpkinperson996 commented Aug 4, 2026

Copy link
Copy Markdown

关联

变更

  • 增加“特训目标”材料页和驱动盘页的 1080p 实机截图。
  • 覆盖动态副本识别、实战模拟室卡数、专业挑战燃竭模式及驱动盘回退。
  • 覆盖体力计划运行次数隔离与设置卡片字段显隐。

验证

  • 76 passed, 4 deselected, 7 warnings
  • Ruff 检查通过。
  • 4 个 deselected 用例是测试仓主线已有、且可在未修改主仓源码复现的过期断言。

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6f5cd19-a63c-4cc9-9f0a-61aa75213163

📥 Commits

Reviewing files that changed from the base of the PR and between ef27de3 and 3a41b09.

📒 Files selected for processing (2)
  • test/zzz_od/application/charge_plan/test_charge_plan_config.py
  • test/zzz_od/backend/test_config_describe.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/zzz_od/application/charge_plan/test_charge_plan_config.py

Summary by CodeRabbit

  • 功能完善
    • 完善“特训目标”计划支持,可根据电量和目标类型自动选择合适内容及模式。
    • 动态计划可继承队伍、自动战斗等设置,并自动重置执行次数。
  • 界面优化
    • 特训目标计划卡片仅展示相关设置,隐藏不适用的副本、次数和数量选项。
  • 问题修复
    • 优化材料、驱动盘、专业挑战及恶名狩猎等目标的推荐、滚动查找与燃竭模式选择。

Walkthrough

新增特训目标的配置描述、计划生命周期、界面显示和动态副本选择测试。测试覆盖电量、卡牌、燃竭模式、计划继承、配置默认值及运行时方法发现。

Changes

特训目标验证

Layer / File(s) Summary
计划配置与生命周期
test/zzz_od/application/charge_plan/test_charge_plan_config.py, test/zzz_od/backend/test_config_describe.py
新增特训目标测试工厂。验证计划选择、完成状态、动态子计划更新、最低电量、配置校验、字段默认值和运行时方法发现。
运行时设置界面
test/zzz_od/gui/view/one_dragon/test_charge_plan_interface.py
验证特训目标卡片仅显示预设队伍和自动战斗设置,并隐藏副本及次数控件。
动态副本选择
test/zzz_od/operation/compendium/test_choose_training_goal.py
验证不同目标的电量匹配、卡牌数量、推荐选择、滚动查找、燃竭模式和动态计划继承。

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: doctorreid

Poem

我是小兔,检查测试篮,
特训目标已排成行。
电量卡牌完成校验,
动态计划继承配置。
界面控件清晰显示,
轻轻一跳,测试通过。

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了为 charge_plan 增加特训目标动态计划测试的主要变更。
Description check ✅ Passed 描述与测试覆盖、截图、运行次数隔离和控件显隐等变更直接相关。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pumpkinperson996

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant