Resize window if logging area is hidden/shown#126
Open
martonmiklos wants to merge 4 commits intoOpen-Agriculture:mainfrom
Open
Resize window if logging area is hidden/shown#126martonmiklos wants to merge 4 commits intoOpen-Agriculture:mainfrom
martonmiklos wants to merge 4 commits intoOpen-Agriculture:mainfrom
Conversation
Member
|
I don't know how I feel on this one... if the user resized it from its initial size it'd be jarring to force set it to some specific size 🤔 |
Contributor
Author
I made the resizing height dynamic on settings change. I also fixed the non visible logging component introduced in #133 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like the show/hide logging area option, however when turned off the window has a great blank area.