Fixes #299 Build nightly: don't skip the build step if workflow was started manually. - #300
Conversation
…ld step if workflow was started manually.
msevestre
left a comment
msevestre
left a comment
There was a problem hiding this comment.
Should we add comment explainign what this all means?
e.g. (start only if xx and started manually?)
avoid logic duplication
added comments. |
| if: needs.get-latest-commit-timespan.outputs.LATEST_COMMIT_TIMESPAN >= 86400 | ||
| needs: build-nightly | ||
| # run only if the build-nightly job was skipped | ||
| if: always() && needs.build-nightly.result == 'skipped' |
There was a problem hiding this comment.
Modified to avoid the duplication of the logic:
Run the cleanup-job only if the build-nightly job was skipped
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #299 by modifying the nightly build workflow to allow manual execution regardless of recent commit activity. The change ensures that when the workflow is triggered manually via workflow_dispatch, the build job runs even if there are no recent commits within the last 24 hours.
Key changes:
- Updated the
build-nightlyjob condition to include manual trigger events - Modified the
cleanup-jobto depend on the build job's completion status rather than commit timespan - Added comprehensive comments explaining the build conditions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The workflow is mostly the same as build-nightly for PK-Sim, MoBi and QualificationRunner (only the |
No description provided.