Conversation
* update core * use dotnet build
Yuri05
requested review from
benjaperez1983,
Copilot,
msevestre and
rwmcintosh
September 17, 2025 10:09
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges the develop branch into main for version 12.1, updating the project from version 12.0 to 12.1. This involves comprehensive version bumps across all project files, package reference updates, and migration from AppVeyor to GitHub Actions for CI/CD.
- Version updates across all project files from 12.0.0 to 12.1.0
- Package reference updates to newer versions (OSPSuite packages from 12.0.362 to 12.1.128)
- CI/CD migration from AppVeyor to GitHub Actions with new workflows
Reviewed Changes
Copilot reviewed 27 out of 70 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Project files (.csproj) | Version updates and package reference bumps to 12.1.x versions |
| Tests | New operating system detection tests and version condition additions |
| Core configuration | Refactored registry path access with static imports |
| Operating system detection | Enhanced Windows 11 detection logic with build number checking |
| Data files | Updated batch file configurations and added new test data |
| CI/CD files | Complete migration from AppVeyor to GitHub Actions workflows |
| Documentation | Updated build status badges and license links |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rwmcintosh
approved these changes
Sep 17, 2025
Member
|
Core update required |
Member
Author
Why? It has the latest 12.1 Core (12.1.128) ➡️ https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/actions/workflows/build-and-publish.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge develop ➡️ main before release.