Skip to content

Fixes #326 Update dimensions - #327

Merged
Yuri05 merged 1 commit into
Open-Systems-Pharmacology:developfrom
Yuri05:dimensions_12.3
May 20, 2026
Merged

Fixes #326 Update dimensions#327
Yuri05 merged 1 commit into
Open-Systems-Pharmacology:developfrom
Yuri05:dimensions_12.3

Conversation

@Yuri05

@Yuri05 Yuri05 commented May 20, 2026

Copy link
Copy Markdown
Member

Fixes #326 Update dimensions
Also update OSPSuite.Core

Summary by CodeRabbit

  • Chores
    • Updated internal library dependencies and referenced components to their latest stable versions. These updates span multiple project components, including the core application, validation and output comparison tools, and comprehensive test infrastructure. The updates provide access to the latest bug fixes, performance improvements, and enhanced platform compatibility while maintaining consistency across all components.

Review Change Stack

@Yuri05 Yuri05 added the no-review Add to PR before creating to avoid automated code review by CodeRabbit label May 20, 2026
@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 73af02a0-304d-4c08-af36-d85db8beee57

📥 Commits

Reviewing files that changed from the base of the PR and between ab2e4c5 and 4f28ae3.

📒 Files selected for processing (5)
  • dimensions
  • src/InstallationValidator.Core/InstallationValidator.Core.csproj
  • src/InstallationValidator/InstallationValidator.csproj
  • src/SimulationOutputComparer/SimulationOutputComparer.csproj
  • tests/InstallationValidator.Tests/InstallationValidator.Tests.csproj

📝 Walkthrough

Walkthrough

This PR updates the dimensions submodule pointer and upgrades OSPSuite package dependencies from version 12.3.1 to 12.3.32 across five project files: the core library, test projects, and two application projects. No build logic or public entity declarations are modified.

Changes

Dependency Updates

Layer / File(s) Summary
Dimensions submodule update
dimensions
Submodule pointer updated to a new commit SHA.
Core and test project dependencies
src/InstallationValidator.Core/InstallationValidator.Core.csproj, tests/InstallationValidator.Tests/InstallationValidator.Tests.csproj
OSPSuite packages (OSPSuite.Core, OSPSuite.Infrastructure, OSPSuite.Infrastructure.Castle, OSPSuite.UI) bumped from 12.3.1 to 12.3.32; OSPSuite.Utility and OSPSuite.TeXReporting remain unchanged.
Application project dependencies
src/InstallationValidator/InstallationValidator.csproj, src/SimulationOutputComparer/SimulationOutputComparer.csproj
OSPSuite.Core and OSPSuite.UI updated from 12.3.1 to 12.3.32; other package references unchanged.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 With submodules and versions aligned so clean,
OSPSuite bumps leap from one-point-three to two,
A harmonious dance of dependencies—true,
The installer and comparer now see eye to eye,
All systems synchronize beneath one shared sky! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes secondary updates to OSPSuite NuGet packages across multiple project files beyond the dimensions submodule update mentioned in the PR title. Clarify whether OSPSuite package updates are necessary for issue #326 or separate concerns; consider splitting into dedicated PR if unrelated to dimensions update.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the dimensions submodule referenced in the pull request, which is the primary objective stated in the PR description.
Linked Issues check ✅ Passed The PR updates the dimensions submodule commit as intended by issue #326, meeting the core requirement without explicit coding standards to verify.
Description check ✅ Passed The PR description adequately explains the main change and acknowledges the secondary OSPSuite.Core update, though additional context on package update rationale would be beneficial.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Yuri05
Yuri05 requested review from msevestre and rwmcintosh May 20, 2026 11:27
@Yuri05
Yuri05 merged commit aec7f3a into Open-Systems-Pharmacology:develop May 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-review Add to PR before creating to avoid automated code review by CodeRabbit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update dimensions

2 participants