Skip to content

Fix build scripts for net10.0-windows output paths - #338

Merged
Yuri05 merged 2 commits into
developfrom
fix-net10-setup-paths
Jul 16, 2026
Merged

Fix build scripts for net10.0-windows output paths#338
Yuri05 merged 2 commits into
developfrom
fix-net10-setup-paths

Conversation

@rwmcintosh

@rwmcintosh rwmcintosh commented Jul 16, 2026

Copy link
Copy Markdown
Member

Fixes #339

The Build Nightly 13.0 workflow failed at the Create Setup step:

Errno::ENOENT: No such file or directory @ apply2files - .../setup/deploy/harvest/InstallationValidator.exe

The projects target net10.0-windows, but the build scripts still referenced the old net472 output folder.

  • rakefile.rb: harvest source bin/<config>/net472 -> net10.0-windows (fixes the failure), and the postclean data folder 12.3 -> 13.0.
  • dotcover.xml: coverage target dll path net472 -> net10.0-windows.
  • InstallationValidator.sln: solution-folder reference to the renamed nightly (build-nightly_12.3.yml -> build-nightly_13.0.yml).

After this merges, re-run Build Nightly 13.0 to produce the "Installation Validator Installer 13.0.x" artifact the Suite build needs.

🤖 Generated with Claude Code

The nightly's create_setup failed because rakefile still harvested from the
net472 output folder. Point it (and dotcover + the postclean data folder) at
net10.0-windows/13.0, and update the .sln reference to the renamed nightly.
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rwmcintosh, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 32 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6460e63b-b78c-4508-a214-8bafc955d069

📥 Commits

Reviewing files that changed from the base of the PR and between ea08263 and b8ea01a.

📒 Files selected for processing (4)
  • InstallationValidator.sln
  • README.md
  • dotcover.xml
  • rakefile.rb
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-net10-setup-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rwmcintosh
rwmcintosh requested a review from Yuri05 July 16, 2026 16:32
@Yuri05
Yuri05 merged commit 511dd0e into develop Jul 16, 2026
2 checks passed
@Yuri05
Yuri05 deleted the fix-net10-setup-paths branch July 16, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Nightly 13.0 fails at Create Setup: build scripts still reference net472 output paths

2 participants