Version 12.3 by Yuri05 · Pull Request #2411 · Open-Systems-Pharmacology/MoBi

Yuri05 · 2026-05-31T18:29:28Z

Description

Merge develop ➡️ main before release.

Type of change

Please mark relevant options with an x in the brackets.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires documentation changes (link at least one user or developer documentation issue):
Algorithm update - updates algorithm documentation/questions/answers etc.
Other (please describe): Merge develop ➡️ main before release.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Integration tests
Unit tests
Manual tests
No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

Check if the code is well documented
Check if the behavior is what is expected
Check if the code is well tested
Check if the code is readable and well formatted
Additional checks (document below if any)
Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

* update 12.2 -> 12.3 * fix minor * update core * file naming * update naming and remove environment variables

…when tests fail (#2224)

* use upstream workflow * change job name * Update .github/workflows/build-and-test.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * trigger * remove sln file from build and test * rename the job * use optional solution file name * test without the solution file name * change to main branch for workflow --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fixes #2187 Automatic rename of like-named reactions * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * revert AI suggestion * add more test cases --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* #2235 create context menu for adding initial conditions * #2235 run resharper

* 2714-export-history-to-csv-or-any-other-text-format * #2714 remove dropdown * #2226 update package * #2226 remove unused constants

* #2331 run simulation and preserve the selected node * #2331 format Related Work Items: #2 * #2231 add tests

* Fixes #2239 Add user setting for default parameter grouping * add comment * update to specific enum

* 2121-pkml-export-default-file-name * #2121 spatialstructure naming * #2121 specs * #2121 remove usings * #2121 code changes for review * #2121 fix module * #2121 code changes * #2121 specs implement objectResolver * #2121 entityType instead of entityName

…except top container (#2244) * Fixes #1157 "Events" should not be allowed as name for any container * make it easier to understand * pr comments * exclude "Events" when there's no explicit prohibited names, and the container is not in a spatial structure * PR feedback * refactor test * add comments

…#2256) * Fixes #1405 Check for "NaN" and "Inf" values upon creating a model configuration. * update core * rename * add a test

* #2206 it is possible create duplicate formula with same name * #2206 PR Comment by AI

* Initial plan * Fix crash when importing SBML model with non-Module parent in AddedEvent handler Co-authored-by: Yuri05 <25061876+Yuri05@users.noreply.github.com> * Clean up: remove redundant null check for module in refreshModuleIcon, improve test assertion Co-authored-by: Yuri05 <25061876+Yuri05@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Yuri05 <25061876+Yuri05@users.noreply.github.com>

…nsion module back to PK-Sim module (#2286)

…he applications are organized (#2295) * Fixes #2291 For multiple doses, use the presentation to clean up how the applications are organized * pr feedback

#2289) * 2280-renaming-molecules-to-existing-molecules-in-the-project-validation-fails * #2280 forbidden names retireiver * like named molecules only, not from IC. * rename --------- Co-authored-by: Robert McIntosh <261477+rwmcintosh@users.noreply.github.com>

…2305) * Fixes #548 import of initial conditions does not overwrite existing * move up * check for whitespace

In order to be able running build-nightly_v13.yml on dispatch from v13 branch

…shown (#2354)

)

…er contract (#2384) OSPSuite.Core's CreateDistributedParameter now pre-creates the sub-parameters referenced by the distribution formula (Mean, Deviation/GeometricDeviation/Minimum/Maximum, Percentile). This requires MoBi's three callers of the mapper/factory to be adjusted so they no longer add duplicate sub-parameters or apply the value redundantly. PathAndValueEntityToDistributedParameterMapper: when a caller-supplied sub-parameter overlaps a factory-created one, update the existing child's value instead of calling Add (which would throw NotUniqueNameException). New unit test covers this case. IndividualParameterToParameterDTOMapper / SpatialStructureContentExporter: the OSPSuite.Core mapper now applies the value internally (constant formula for plain parameters, fixed value via Value setter for distributed). The redundant constant-formula assignment is removed and IFormulaFactory is no longer needed in either class.

Co-authored-by: Yuri05 <Yuri05@github.com>

coderabbitai · 2026-05-31T18:29:35Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)

no-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0ac08d9-1d5f-4c38-a604-d1be46791cbc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rwmcintosh and others added 30 commits January 14, 2026 12:42

Update builds to 12 3 (#2220)

ed6ee29

* update 12.2 -> 12.3 * fix minor * update core * file naming * update naming and remove environment variables

add push trigger (#2221)

60ea95e

Fixes #2223 Always upload test log artifacts in nightly builds, even …

3833f4a

…when tests fail (#2224)

Fixes #2186 Rename reaction on load should update formula paths (#2236)

7462788

#2235 create context menu for adding initial conditions (#2237)

5452ee1

* #2235 create context menu for adding initial conditions * #2235 run resharper

2226 export history to csv or any other text format (#2227)

5a1430c

* 2714-export-history-to-csv-or-any-other-text-format * #2714 remove dropdown * #2226 update package * #2226 remove unused constants

#2231 run simulation and preserve the selected node (#2241)

dd8e64d

* #2331 run simulation and preserve the selected node * #2331 format Related Work Items: #2 * #2231 add tests

Fixes #2239 Add user setting for default parameter grouping (#2240)

04c7e79

* Fixes #2239 Add user setting for default parameter grouping * add comment * update to specific enum

2230 when cloning a simulation the chart is not cloned (#2245)

97e1b2e

update core (#2247)

5a61853

1405 check for nan and inf values upon creating a model configuration (…

0da7cb4

…#2256) * Fixes #1405 Check for "NaN" and "Inf" values upon creating a model configuration. * update core * rename * add a test

update core (#2261)

0f367ab

#1964 parameters from reaction (#2283)

98368bb

update core (#2285)

91e6d0a

#2206 it is possible create duplicate formula with same name (#2288)

990aad3

* #2206 it is possible create duplicate formula with same name * #2206 PR Comment by AI

Fixes #2083 Undo of Change molecule start amount does not revert Exte…

7db7b02

…nsion module back to PK-Sim module (#2286)

Fixes #2291 For multiple doses, use the presentation to clean up how …

b132ff7

…he applications are organized (#2295) * Fixes #2291 For multiple doses, use the presentation to clean up how the applications are organized * pr feedback

update core (#2300)

df446dc

Fixes #548 import of initial conditions does not overwrite existing (#…

6ea7437

…2305) * Fixes #548 import of initial conditions does not overwrite existing * move up * check for whitespace

Fixes #2306 Remove classifications when removing modules (#2307)

986eacc

Create build-nightly_v13.yml (#2309)

94fba38

In order to be able running build-nightly_v13.yml on dispatch from v13 branch

Fixes #2100 New Parameter Value: parameters of the reactions are not …

41dd82d

…shown (#2354)

update core (#2355)

d051085

Fixes #2057 Events: Assignments: show parameters from Individuals (#2365

ec6a776

)

msevestre and others added 3 commits May 11, 2026 15:55

Fixes #2398 Update dimensions (#2401)

4530d59

Co-authored-by: Yuri05 <Yuri05@github.com>

update OSPSuite.Core to the latest 12.3 (#2408)

25b624a

Co-authored-by: Yuri05 <Yuri05@github.com>

Yuri05 added the no-review Add to PR before creating to avoid automated code review by CodeRabbit label May 31, 2026

Yuri05 requested review from msevestre and rwmcintosh May 31, 2026 18:32

rwmcintosh approved these changes Jun 1, 2026

View reviewed changes

Yuri05 merged commit 7f1094c into main Jun 1, 2026
21 of 24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Version 12.3#2411

Version 12.3#2411
Yuri05 merged 33 commits into
mainfrom
develop

Yuri05 commented May 31, 2026

Uh oh!

coderabbitai Bot commented May 31, 2026 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Yuri05 commented May 31, 2026

Description

Type of change

How Has This Been Tested?

Reviewer checklist

Screenshots (if appropriate):

Questions (if appropriate):

Uh oh!

coderabbitai Bot commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented May 31, 2026 •

edited

Loading