Skip to content

Update to .NET 10#20

Merged
rwmcintosh merged 1 commit into
mainfrom
19-update-to-net10
May 7, 2026
Merged

Update to .NET 10#20
rwmcintosh merged 1 commit into
mainfrom
19-update-to-net10

Conversation

@rwmcintosh

@rwmcintosh rwmcintosh commented May 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Retarget all projects (OSPSuite.DataBinding, tests, starter) from net8.0-windows to net10.0-windows.
  • Bump OSPSuite.Utility reference from 4.1.1.45.0.0.6 (the .NET 10 build).
  • Bump published package major: 3.0.14.0.0.
  • Modernize both GHA workflows: actions/checkout@v6, actions/setup-dotnet@v5 (10.x), actions/upload-artifact@v7. Drop microsoft/setup-msbuild and build with dotnet build/test/pack to avoid the VS 2022 17.14 net10 warning. Recursive testLog glob (./**/testLog*.html).
  • Add explicit permissions: blocks to both workflows (packages: write + contents: read on publish, packages: read + contents: read on PR build) to clear code-scanning warnings.
  • Drop redundant Microsoft.CSharp PackageReference from the test project (NU1510 — pruned by net10).

Test plan

  • dotnet build clean (0 warnings, 0 errors)
  • dotnet test — 53/53 passed locally
  • dotnet pack succeeds; produced OSPSuite.DataBinding.4.0.0.nupkg
  • PR build workflow runs green on GHA
  • After merge, publish workflow pushes 4.0.0.x to GitHub Packages

Fixes #19
Fixes #18

Retarget all projects to net10.0-windows, bump OSPSuite.Utility to 5.0.0.6,
update GHA to current majors, switch managed build to dotnet (avoids the
VS 2022 17.14 net10 warning), and add explicit permissions to both workflows.

Fixes #19
Fixes #18
@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@rwmcintosh has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 15 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9f35a6ab-3c9b-4ecf-95d1-c3283d7d6b37

📥 Commits

Reviewing files that changed from the base of the PR and between fdaab30 and ecb6c3c.

📒 Files selected for processing (5)
  • .github/workflows/build-and-publish.yml
  • .github/workflows/build-pr.yml
  • src/OSPSuite.DataBinding/OSPSuite.DataBinding.csproj
  • tests/OSPSuite.DataBinding.Starter/OSPSuite.DataBinding.Starter.csproj
  • tests/OSPSuite.DataBinding.Tests/OSPSuite.DataBinding.Tests.csproj
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 19-update-to-net10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rwmcintosh
rwmcintosh requested review from Yuri05 and msevestre May 7, 2026 18:29
@rwmcintosh rwmcintosh self-assigned this May 7, 2026
@rwmcintosh
rwmcintosh merged commit bbfffd1 into main May 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to .NET 10 Add explicit GHA permissions to avoid code scanning warnings

2 participants