feat: show loading spinner and success states on user profile and imp…#1462
Open
Kartikupadhyay44 wants to merge 1 commit into
Open
feat: show loading spinner and success states on user profile and imp…#1462Kartikupadhyay44 wants to merge 1 commit into
Kartikupadhyay44 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ort modal (#590)
name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''
What type of PR is this?(check all applicable)
Description
Related Issues
Issue #590
What this PR achieves
This PR fixes the abrupt closing behavior of the Mountain Project import modal and provides clear asynchronous feedback to the user during data ingestion.
loadingstate withingetTicks()to trigger an active loading screen.animate-spincircle element paired with text ("Fetching ticks from Mountain Project...") while the background network request is active.importedCountstate tracker to display a clean completion card inside the modal upon successful data fetching, including explicit navigation links and safe closure handlers.closeOnEsc={!loading}) during active network transport to prevent truncated mutations.ImportFromMtnProj.test.tsxensuring full mocking validation for both active spinner rendering and final success layouts.Screenshots, recordings
Notes
All unit tests and
ts-standardlint checks pass successfully locally. The Next.js production build compiles perfectly without errors.