Skip to content

Ignore 401/403 errors when requesting queues#3598

Open
jmthomas wants to merge 1 commit into
mainfrom
fix/3452-cmdsender-queue-list-permissions
Open

Ignore 401/403 errors when requesting queues#3598
jmthomas wants to merge 1 commit into
mainfrom
fix/3452-cmdsender-queue-list-permissions

Conversation

@jmthomas

@jmthomas jmthomas commented Jul 21, 2026

Copy link
Copy Markdown
Member

I ran through the entire sequence in 7.2.1 and could not reproduce any error message when visiting Command Sender. @ryanmelt please update the issue with reproduction steps.

closes #3452

Created new role inst-only. Created new user insty with new realm role ALLSCOPES__inst-only. Logged in and observed user could not send INST2 command:

Screenshot 2026-07-21 at 12 00 35 PM

Refreshing page shows no errors. Can send INST ABORT command:

image

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.83%. Comparing base (63a7272) to head (ade8667).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3598      +/-   ##
==========================================
- Coverage   79.84%   79.83%   -0.02%     
==========================================
  Files         694      694              
  Lines       58309    58309              
  Branches      728      728              
==========================================
- Hits        46556    46549       -7     
- Misses      11675    11682       +7     
  Partials       78       78              
Flag Coverage Δ
python 81.22% <ø> (ø)
ruby-api 81.10% <ø> (-0.15%) ⬇️
ruby-backend 83.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmthomas
jmthomas requested a review from ryanmelt July 21, 2026 17:08
@ryanmelt

Copy link
Copy Markdown
Member

If the user has cmd_info only for one target, they will get a 403 error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CmdSender with limited permissions (only 1 target allowed) creates errors when querying the list of queues

2 participants