chore(deps-dev): bump eslint from 8.57.1 to 10.1.0#64
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/eslint-10.1.0
branch
from
732cfd1 to
2f63023
Compare
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/eslint-10.1.0
branch
from
2f63023 to
81992c0
Compare
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 10.1.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v8.57.1...v10.1.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/eslint-10.1.0
branch
from
81992c0 to
59e7e64
Compare
hqhq1025
added
bot-rerun
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings
- [Major] ESLint 10 bump breaks dependency installation. The PR updates
eslintto^10.2.1, but the new lockfile still records@typescript-eslint/eslint-plugin/@typescript-eslint/utilspeers aseslint: ^8.56.0andeslint-plugin-react-hooksas^8.0.0-0, sonpm ci --ignore-scriptsfails withERESOLVEbefore CI can reach lint or tests. Evidencepackage.json:117,package-lock.json:4978,package-lock.json:5007,package-lock.json:5035,package-lock.json:8297,.github/workflows/ci.yml:25
Suggested fix:If the goal is ESLint 10, upgrade the related lint plugins in the same PR and regenerate{ "devDependencies": { "eslint": "^8.56.0" } }package-lock.json.
Summary
Review mode: initial
1 issue found: the dependency set on the PR head is not installable with npm ci, so the CI pipeline cannot reach lint or tests.
Testing
- Reproduced by running
npm ci --ignore-scriptsin a temp directory populated from the PR head'spackage.jsonandpackage-lock.json; it failed withERESOLVEunder Nodev20.20.2/ npm10.8.2 - Suggested follow-up after fixing versions:
npm ci --ignore-scripts && npm run lint
Open Cowork Bot
| "electron": "^35.7.5", | ||
| "electron-builder": "^26.8.1", | ||
| "eslint": "^8.56.0", | ||
| "eslint": "^10.2.1", |
There was a problem hiding this comment.
[MAJOR] This bump makes the PR head un-installable. The updated lockfile still pins @typescript-eslint/eslint-plugin / @typescript-eslint/utils to eslint: ^8.56.0 (package-lock.json:4978, package-lock.json:5007, package-lock.json:5035) and eslint-plugin-react-hooks to ^8.0.0-0 (package-lock.json:8297), so npm ci --ignore-scripts fails with ERESOLVE before CI reaches lint or tests (.github/workflows/ci.yml:25).
Suggested fix:
{
"devDependencies": {
"eslint": "^8.56.0"
}
}If you want ESLint 10 here, upgrade the lint plugins in the same PR and regenerate the lockfile.
|
Superseded by #213. |
1 participant
Bumps eslint from 8.57.1 to 10.1.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
8351ec710.1.03270bc1Build: changelog update for 10.1.0a9f9ccechore: update dependency eslint-plugin-unicorn to ^63.0.0 (#20584)1f42bd7chore: updateprettierto 3.8.1 (#20651)c0a6f4achore: update dependency@eslint/jsonto ^1.2.0 (#20652)cc43f79chore: update dependency c8 to v11 (#20650)2ce4635chore: update dependency@eslint/jsonto v1 (#20649)f0406eechore: update dependency markdownlint-cli2 to ^0.21.0 (#20646)dbb4c95chore: remove trunk (#20478)ff4382bfeat: apply fix forno-varinTSModuleBlock(#20638)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)