Add OCP global pull secret in image version checks#848
Draft
Conversation
leochr
reviewed
Mar 18, 2026
| olappSecrets := []corev1.Secret{} | ||
|
|
||
| // check the OpenShift global pull secret for inclusion | ||
| if len(r.watchNamespaces) == 0 && r.IsOpenShift() { |
Member
There was a problem hiding this comment.
Should the IsClusterWide util method be used instead?
Member
Author
There was a problem hiding this comment.
Added isClusterWide to the ReconcileOpenLiberty
| } | ||
| } | ||
| } | ||
| return libertyimage.NewNamespaceCredentialsContext(reqLogger, olappSecrets, olapp.GetNamespace()).GetContainerImageMetadata(context.TODO(), imageRef, pullSecret, false) |
Member
There was a problem hiding this comment.
Noticed that the pullSecret would be the last secret if multiple pull secrets were specified. Would that be okay?
Member
Author
There was a problem hiding this comment.
Order matters on registry collisions (execute first seen registry first) so I can prioritize the CR-specific pull secrets before the global one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?:
Does this PR introduce a user-facing change?
CHANGELOG.mdWhich issue(s) this PR fixes:
Fixes #