Skip to content

fix(panel): correct cluster mode detection and error surfacing - #114

Merged
AlexanderWagnerDev merged 4 commits into
mainfrom
fix/bug-hunter-cluster-ui-errors
Aug 10, 2026
Merged

fix(panel): correct cluster mode detection and error surfacing#114
AlexanderWagnerDev merged 4 commits into
mainfrom
fix/bug-hunter-cluster-ui-errors

Conversation

@AlexanderWagnerDev

@AlexanderWagnerDev AlexanderWagnerDev commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Detect cluster mode via /cluster enabled (not via successful cluster_streams, which standalone also serves).
  • On list_streams failure, resolve cluster via health so confirmed standalone hides Cluster nav.
  • Surface cluster_status errors on /cluster instead of silently rendering standalone.

Companion server PR: OpenRTMP/librtmp2-server#151

Test plan

  • CI tests/test_cluster_ui.py
  • Health down + cluster.enabled=false: no false Cluster mode on index
  • Health down + cluster.enabled=true: Cluster mode + placement still load
  • Streams fail + health standalone: no Cluster nav
  • Health looks standalone + /cluster timeout: error shown, not silent standalone

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes
    • Improved cluster health detection by using authoritative cluster status information.
    • Preserved accurate navigation states when stream loading fails or cluster health is unknown.
    • Displayed cluster status API errors in the cluster overview instead of hiding them.
    • Prevented unnecessary cluster interface elements and requests in explicitly standalone deployments.
    • Improved handling of placement loading and standalone responses during uncertain cluster conditions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@AlexanderWagnerDev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6c7f71ff-cae0-40df-8773-4f214262b140

📥 Commits

Reviewing files that changed from the base of the PR and between 63e90e1 and f2918d3.

📒 Files selected for processing (1)
  • .github/workflows/integration.yml
📝 Walkthrough

Walkthrough

Changes

Cluster state detection

Layer / File(s) Summary
Index cluster resolution
app.py, tests/test_cluster_ui.py
The index flow uses cluster health and /cluster status to resolve unknown states. Cluster streams load only after confirmed cluster enablement. Tests cover failures, standalone responses, status calls, and navigation state.
Cluster overview error reporting
app.py, tests/test_cluster_ui.py
The cluster overview renders /cluster status errors through api_error. Tests verify the updated error message.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant index
  participant client.health
  participant client.cluster_status
  participant client.cluster_streams
  participant template
  index->>client.health: probe cluster health
  client.health-->>index: enabled, standalone, or unknown
  index->>client.cluster_status: resolve unknown state
  client.cluster_status-->>index: explicit enabled state
  index->>client.cluster_streams: fetch streams when enabled
  client.cluster_streams-->>index: return stream data or error
  index->>template: render navigation and cluster state
Loading

Possibly related PRs

Suggested reviewers: claude, cursoragent

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes to cluster mode detection and error handling in the panel.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bug-hunter-cluster-ui-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

AlexanderWagnerDev and others added 3 commits August 10, 2026 16:29
Panel Integration builds librtmp2-server from source; main still ships glibc+gcompat (exit 127). Point at #151 until musl stages merge, then revert to main.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@sonarqubecloud

Copy link
Copy Markdown

@AlexanderWagnerDev
AlexanderWagnerDev merged commit 9cd36cb into main Aug 10, 2026
12 checks passed
@AlexanderWagnerDev
AlexanderWagnerDev deleted the fix/bug-hunter-cluster-ui-errors branch August 10, 2026 15:03
@AlexanderWagnerDev AlexanderWagnerDev mentioned this pull request Aug 10, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant