fix(ci): resolve SonarCloud security rating failures on main - #116
Merged
Conversation
Pin GitHub Actions to full commit SHAs, use locked pip installs with --only-binary in CI/Docker, scope release workflow write permissions to the package job, replace COPY . . with explicit paths plus .dockerignore, and mark intentional RTMP URL generation with nosonar annotations. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
|
AlexanderWagnerDev
marked this pull request as ready for review
August 11, 2026 12:04
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SonarCloud Quality Gate on
mainfails becausenew_security_ratingis C (open vulnerabilities in the new-code period).Changes
docker-multiarch.ymlandrelease.yml(githubactions:S7637)pip install --only-binary :all:with pinnedpytest==9.1.1in CI workflows and Docker build (S8541/S8544)contents: writepermission from workflow scope to thepackagejob inrelease.yml(S8233)COPY . .with explicit paths and add.dockerignore(docker:S6470)# nosonar(python:S5332)Root cause
PR #99 (Renovate) bumped
docker/login-actionto floatingv4.6.0tags, adding S7637 findings; other open Major/Critical issues in the same new-code window also keep the security rating at C.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.