feat: create component - badge by florentmaitre · Pull Request #601 · Orange-OpenSource/ouds-android

florentmaitre · 2025-06-26T17:02:41Z

No description provided.

github-actions · 2025-06-26T17:10:45Z

🟢 Netlify deploy for commit `13505dc` succeeded

Deploy preview: null
Deploy log: https://app.netlify.com/projects/ouds-android/deploys/686fc66f86129476898a5e05

paulinea · 2025-07-02T12:00:21Z

+    <string name="app_components_badge_label">Badge</string>
+    <string name="app_components_badge_description_text">The badge is a small UI element used to highlight status, notifications, or categorization within an interface. It is often displayed as a label or indicator with a distinct background color and text.</string>
+    <string name="app_components_badge_status_label">Status</string>
+    <string name="app_components_badge_size_label">Size</string>
+    <string name="app_components_badge_type_label">Type</string>
+    <string name="app_components_badge_standardType_label">Standard</string>
+    <string name="app_components_badge_countType_label">Count</string>
+    <string name="app_components_badge_iconType_label">Icon</string>
+    <string name="app_components_badge_count_label">Count</string>


We have to add these new strings in the translation file and ask for Arabic translation.

github-actions · 2025-07-08T14:35:00Z

📱 Alpha release available

Scan the QR code below to download and install the Design System Toolbox app which contains the changes of this pull request.
Please note that the link behind this QR code will expire on Tue, 8 Jul 2025 15:34:59 GMT.

jerome-regnier · 2025-07-08T16:20:47Z

Test sur Android :
https://www.figma.com/design/QtOWrH1m3RHOAkfyy0XFil/-OUDS-Core-Lib--Components?node-id=66541-40428&t=Su9ON6sy2LsUZwvq-1
Test effectué sur chaque variant dont le count avec un chiffre >100, affichage +99 ok et tous les autres variant ok.

B3nz01d · 2025-07-09T09:56:59Z

@florentmaitre Here are my feedbacks:
1- to be coherent with the illustration, the default state of the badge component when you arrive on it the first time should be in:

type: Count
size: medium
number: "1" <- it needs to be defaulted to 1, it cannot stay empty
Status: negative
2- When a user is set to xsmall or small and selects the icon or the count type the size should switch to medium automatically
3- when you are on the medium setup and you select the small or xsmall it should switch to the corresponding size in the standard type.

florentmaitre · 2025-07-09T13:51:32Z

@B3nz01d

1 - Yes we can set the badge type to count by default and set count value to 1. However, Figma initial setting for status is neutral and I think that Figma should be the source of truth for default values:

By the way, the default values of our APIs follow Figma initial settings, meaning that the default status value is neutral in our APIs.

2 - Yes.

3 - I agree from a Figma point of view. However, we decided to have only one size type (which is OudsChip.Size) for all our APIs. As a consequence when the user selects OudsChip.Size.ExtraSmall or OudsChip.Size.Small with a count (or icon) badge, the count (or icon) is not displayed and it renders as if it was a standard badge. However, although it looks like a standard badge, practically the API used is still the count (or icon) API, so from an API point of view I think we should not change the type when switching to extra small or small.

florentmaitre linked an issue Jun 26, 2025 that may be closed by this pull request

Create component - Badge #403

Closed

florentmaitre temporarily deployed to netlify June 26, 2025 17:07 — with GitHub Actions Inactive

florentmaitre force-pushed the 403-create-component---badge branch 2 times, most recently from 1fd9fc9 to 93df07a Compare June 27, 2025 10:13

florentmaitre temporarily deployed to netlify June 27, 2025 10:20 — with GitHub Actions Inactive

florentmaitre force-pushed the 403-create-component---badge branch from 93df07a to 0699aa5 Compare June 27, 2025 17:08

florentmaitre temporarily deployed to netlify June 27, 2025 17:16 — with GitHub Actions Inactive

florentmaitre force-pushed the 403-create-component---badge branch from 0699aa5 to 721588d Compare June 30, 2025 10:03

florentmaitre temporarily deployed to netlify June 30, 2025 10:08 — with GitHub Actions Inactive

florentmaitre force-pushed the 403-create-component---badge branch from 721588d to 43821f9 Compare June 30, 2025 16:42

florentmaitre marked this pull request as ready for review June 30, 2025 16:42

florentmaitre temporarily deployed to netlify June 30, 2025 16:49 — with GitHub Actions Inactive

florentmaitre marked this pull request as draft July 1, 2025 07:59

florentmaitre force-pushed the 403-create-component---badge branch from 43821f9 to 15ad341 Compare July 1, 2025 08:34

florentmaitre marked this pull request as ready for review July 1, 2025 08:34

florentmaitre temporarily deployed to netlify July 1, 2025 08:39 — with GitHub Actions Inactive

florentmaitre force-pushed the 403-create-component---badge branch from 15ad341 to 0cd7991 Compare July 1, 2025 10:47

florentmaitre temporarily deployed to netlify July 1, 2025 10:54 — with GitHub Actions Inactive

paulinea requested changes Jul 2, 2025

View reviewed changes

florentmaitre force-pushed the 403-create-component---badge branch from 0cd7991 to 7cea0ed Compare July 3, 2025 11:51

florentmaitre temporarily deployed to netlify July 3, 2025 11:57 — with GitHub Actions Inactive

florentmaitre temporarily deployed to netlify July 4, 2025 15:52 — with GitHub Actions Inactive

paulinea added the ⌛ waiting for validations label Jul 8, 2025

paulinea temporarily deployed to netlify July 8, 2025 13:24 — with GitHub Actions Inactive

github-actions Bot added a commit that referenced this pull request Jul 8, 2025

Add QR code for 'feat: create component - badge (#601)'

2c61e19

jerome-regnier added the 👌 OK Design label Jul 8, 2025

jerome-regnier temporarily deployed to netlify July 8, 2025 16:27 — with GitHub Actions Inactive

florentmaitre temporarily deployed to netlify July 9, 2025 14:10 — with GitHub Actions Inactive

paulinea removed the 👌 OK Design label Jul 10, 2025

paulinea temporarily deployed to netlify July 10, 2025 13:36 — with GitHub Actions Inactive

florentmaitre added 13 commits July 10, 2025 15:44

Add OudsBadge

3a82b75

Add tests for OudsBadge

e962cad

Add samples and KDoc for OudsBadge

27edc3c

Add OudsBadge demo

8ce02e1

Change log level of checkNotice Gradle task

a4edfa2

Enhance OudsBadge previews

dbd39a9

Fix UI bug when increasing text size

37abd1a

Update Paparazzi snapshots following tokens update

8747dc9

Fix minor graphical bug in badge demo screen

789bbb5

Review: Add KDoc for OudsBadge.Status enum class

b592426

Review: Add instrumented tests for OudsBadge

a50c657

Review: Update behaviour of badge demo

e24959c

Add Arabic translation

13505dc

florentmaitre force-pushed the 403-create-component---badge branch from 1f157f2 to 13505dc Compare July 10, 2025 13:44

florentmaitre temporarily deployed to netlify July 10, 2025 13:52 — with GitHub Actions Inactive

paulinea approved these changes Jul 10, 2025

View reviewed changes

paulinea merged commit 0cb19f4 into develop Jul 10, 2025
9 checks passed

paulinea deleted the 403-create-component---badge branch July 10, 2025 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: create component - badge - #601

feat: create component - badge#601
paulinea merged 13 commits into
developfrom
403-create-component---badge

florentmaitre commented Jun 26, 2025

Uh oh!

github-actions Bot commented Jun 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulinea Jul 2, 2025

Uh oh!

Uh oh!

github-actions Bot commented Jul 8, 2025

Uh oh!

jerome-regnier commented Jul 8, 2025

Uh oh!

B3nz01d commented Jul 9, 2025 •

edited

Loading

Uh oh!

florentmaitre commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

florentmaitre commented Jun 26, 2025

Uh oh!

github-actions Bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Netlify deploy for commit 13505dc succeeded

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulinea Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 8, 2025

📱 Alpha release available

Uh oh!

jerome-regnier commented Jul 8, 2025

Uh oh!

B3nz01d commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

florentmaitre commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jun 26, 2025 •

edited

Loading

🟢 Netlify deploy for commit `13505dc` succeeded

B3nz01d commented Jul 9, 2025 •

edited

Loading