Skip to content

326 create component phone number input - #338

Merged
AhmedAmineZr merged 77 commits into
developfrom
326-create-component---phone-number-input
Dec 16, 2025
Merged

326 create component phone number input#338
AhmedAmineZr merged 77 commits into
developfrom
326-create-component---phone-number-input

Conversation

@AhmedAmineZr

@AhmedAmineZr AhmedAmineZr commented Aug 26, 2025

Copy link
Copy Markdown
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes: #497
Closes: #498

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@AhmedAmineZr AhmedAmineZr linked an issue Aug 26, 2025 that may be closed by this pull request
@AhmedAmineZr AhmedAmineZr self-assigned this Aug 26, 2025
@AhmedAmineZr AhmedAmineZr added ⚛️ component 📖 documentation Improvements or additions to documentation 📱 demo app 🧰 library ⭐ v1.0 Tickets needed for mobile v1.0 release labels Aug 26, 2025
@AhmedAmineZr
AhmedAmineZr force-pushed the 326-create-component---phone-number-input branch 3 times, most recently from 2e8cbe5 to bcb1c5c Compare September 3, 2025 21:44
@AhmedAmineZr
AhmedAmineZr force-pushed the 326-create-component---phone-number-input branch 3 times, most recently from 2a3b0db to 661e422 Compare September 19, 2025 16:17
Comment thread ouds_core/lib/components/text_input/ouds_phone_number_input.dart Outdated
@AhmedAmineZr
AhmedAmineZr force-pushed the 326-create-component---phone-number-input branch 2 times, most recently from 7d86399 to 297f20e Compare September 24, 2025 11:02
@AhmedAmineZr
AhmedAmineZr marked this pull request as ready for review September 24, 2025 13:32
@AhmedAmineZr
AhmedAmineZr force-pushed the 326-create-component---phone-number-input branch 2 times, most recently from 46e744e to 8f973fe Compare September 25, 2025 13:51
@Tayebsed93

Tayebsed93 commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

hello @AhmedAmineZr,

  1. Always allow entering 0, even when the number starts with a +, to support users who make mistakes.
Capture d’écran 2025-09-26 à 11 54 11
  1. For the refactoring, create a form_fields folder and put everything inside it. The shared files will be called FormField.
form_fields/
  text_input/
    text_input.dart
  phone_number/
    phone_number_input.dart
  1. We are getting this error:
======== Exception caught by services library ======================================================
The following assertion was thrown during method call TextInputClient.updateEditingState:
Range start 17 is out of text of length 8
'package:flutter/src/services/text_input.dart':
Failed assertion: line 1130 pos 7: 'range.start >= 0 && range.start <= text.length'
Capture d’écran 2025-09-26 à 11 52 31
  1. In the initial settings, the country selector is enabled with enabled = true by default.
Capture d’écran 2025-09-26 à 11 51 26

Comment thread NOTICE.txt
Comment thread app/lib/ui/components/text_input/text_input_code_generator.dart Outdated
Comment thread ouds_theme_contract/lib/ouds_component_version.dart Outdated
Comment thread app/lib/ui/components/text_input/text_input_customization_utils.dart Outdated
Comment thread app/lib/ui/components/form_input/form_fields_customization.dart
Comment thread app/lib/ui/components/text_input/text_input_customization.dart Outdated
Comment thread ouds_core/lib/components/form_input/ouds_phone_number_input.dart Outdated
Comment thread ouds_core/lib/components/form_input/ouds_phone_number_input.dart Outdated
Comment thread ouds_core/lib/components/text_input/ouds_phone_number_input.dart Outdated
Comment thread ouds_core/lib/components/text_input/ouds_phone_number_input.dart Outdated
Comment thread app/lib/ui/components/form_input/phone_number/phone_number_input_demo_screen.dart Outdated
@AhmedAmineZr
AhmedAmineZr force-pushed the 326-create-component---phone-number-input branch 4 times, most recently from 1de2658 to 8e261f4 Compare October 2, 2025 16:18
# Conflicts:
#	app/lib/l10n/gen/ouds_flutter_app_localizations.dart
#	app/lib/l10n/gen/ouds_flutter_app_localizations_ar.dart
#	app/lib/l10n/gen/ouds_flutter_app_localizations_en.dart
#	app/lib/ui/utilities/customizable/customizable_textfield.dart
@AhmedAmineZr
AhmedAmineZr force-pushed the 326-create-component---phone-number-input branch from 78ca50d to 8d40f83 Compare November 20, 2025 13:26
@AhmedAmineZr AhmedAmineZr added TestFlight blocking iOS issue: TestFlight unavailable. We’ve created this label while we fix it and removed ⌛ waiting for validations labels Dec 4, 2025
# Conflicts:
#	app/CHANGELOG.md
#	app/lib/l10n/gen/ouds_flutter_app_localizations_ar.dart
#	app/lib/ui/components/components.dart
@AhmedAmineZr AhmedAmineZr removed the TestFlight blocking iOS issue: TestFlight unavailable. We’ve created this label while we fix it label Dec 11, 2025
@AhmedAmineZr
AhmedAmineZr merged commit d1e8b0c into develop Dec 16, 2025
1 check passed
@AhmedAmineZr
AhmedAmineZr deleted the 326-create-component---phone-number-input branch December 16, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants