Skip to content

feat(checkbox,radio-button,switch): update design - #490

Merged
Tayebsed93 merged 29 commits into
developfrom
437-component-update-standalone-checkbox-and-radio-button-rounded-corners
Dec 1, 2025
Merged

feat(checkbox,radio-button,switch): update design#490
Tayebsed93 merged 29 commits into
developfrom
437-component-update-standalone-checkbox-and-radio-button-rounded-corners

Conversation

@Tayebsed93

@Tayebsed93 Tayebsed93 commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #465, #466, #467, #437, #434, #431, #433

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@Tayebsed93
Tayebsed93 marked this pull request as ready for review November 17, 2025 21:04
@Tayebsed93 Tayebsed93 self-assigned this Nov 17, 2025
@Tayebsed93
Tayebsed93 force-pushed the 437-component-update-standalone-checkbox-and-radio-button-rounded-corners branch from de3e457 to 4b31015 Compare November 18, 2025 10:46
…and-radio-button-rounded-corners

# Conflicts:
#	app/CHANGELOG.md
#	ouds_core/CHANGELOG.md
@Tayebsed93
Tayebsed93 force-pushed the 437-component-update-standalone-checkbox-and-radio-button-rounded-corners branch from 115cf1b to 97fee74 Compare November 18, 2025 14:04
@AhmedAmineZr
AhmedAmineZr self-requested a review November 19, 2025 15:32
@Tayebsed93

Copy link
Copy Markdown
Contributor Author

📣 New Firebase App Distribution Alpha upload available 🚀 (Android)

Please, get the new build from App Tester app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: DesignToolbox (alpha) (510)
Version: 0.6.0
Build type: Alpha
Build details (GitHub): 466
cc @B3nz01d (product owner)
cc @Tayebsed93 @nouha06 @AhmedAmineZr (dev team)
cc @jerome-regnier (design team)

@Tayebsed93

Copy link
Copy Markdown
Contributor Author

📣 New TestFlight Alpha upload available 🚀 (iOS)

Please, get the new build from TestFlight app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: Design Toolbox Flutter (510)
Version: 0.6.0
Build type: Alpha
Build details (GitHub): 466
cc @B3nz01d (product owner)
cc @Tayebsed93 @AhmedAmineZr @nouha06 (dev team)
cc @jerome-regnier (design team)
cc @pya35 (Accessibility)

@jerome-regnier

Copy link
Copy Markdown
Member

@Tayebsed93
Tayebsed93 force-pushed the 437-component-update-standalone-checkbox-and-radio-button-rounded-corners branch from 71c7185 to 632d675 Compare November 24, 2025 15:53
@Tayebsed93

Copy link
Copy Markdown
Contributor Author

📣 New Firebase App Distribution Alpha upload available 🚀 (Android)

Please, get the new build from App Tester app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: DesignToolbox (alpha) (517)
Version: 0.6.0
Build type: Alpha
Build details (GitHub): 490
cc @B3nz01d (product owner)
cc @Tayebsed93 @nouha06 @AhmedAmineZr (dev team)
cc @jerome-regnier (design team)

@Tayebsed93

Copy link
Copy Markdown
Contributor Author

📣 New TestFlight Alpha upload available 🚀 (iOS)

Please, get the new build from TestFlight app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: Design Toolbox Flutter (517)
Version: 0.6.0
Build type: Alpha
Build details (GitHub): 490
cc @B3nz01d (product owner)
cc @Tayebsed93 @AhmedAmineZr @nouha06 (dev team)
cc @jerome-regnier (design team)
cc @pya35 (Accessibility)

@jerome-regnier

Copy link
Copy Markdown
Member

Review Figma :

Checkbox :
https://www.figma.com/design/yKtkEY1DOl7YDvmt7jq0QF/-OUDS-Core-Lib--Review?node-id=70108-18687&t=uSmBO8R4dlXxMZ0X-1
Radio button :
https://www.figma.com/design/yKtkEY1DOl7YDvmt7jq0QF/-OUDS-Core-Lib--Review?node-id=70108-18688&t=uSmBO8R4dlXxMZ0X-1
Switch :
https://www.figma.com/design/yKtkEY1DOl7YDvmt7jq0QF/-OUDS-Core-Lib--Review?node-id=70108-18717&t=uSmBO8R4dlXxMZ0X-1

Pour le chekcbox et le radio button :
Il y a un problème de padding inline ce qui décale la check par exemple. On le voit également en se calant sur la check et ça décale donc le text.
Pour le switch :
Décalage de l’icône error dans le state Error

@Tayebsed93

Copy link
Copy Markdown
Contributor Author

📣 New Firebase App Distribution Alpha upload available 🚀 (Android)

Please, get the new build from App Tester app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: DesignToolbox (alpha) (520)
Version: 0.6.0
Build type: Alpha
Build details (GitHub): 490
cc @B3nz01d (product owner)
cc @Tayebsed93 @nouha06 @AhmedAmineZr (dev team)
cc @jerome-regnier (design team)

@Tayebsed93

Copy link
Copy Markdown
Contributor Author

📣 New TestFlight Alpha upload available 🚀 (iOS)

Please, get the new build from TestFlight app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: Design Toolbox Flutter (520)
Version: 0.6.0
Build type: Alpha
Build details (GitHub): 490
cc @B3nz01d (product owner)
cc @Tayebsed93 @AhmedAmineZr @nouha06 (dev team)
cc @jerome-regnier (design team)
cc @pya35 (Accessibility)

@Tayebsed93

Tayebsed93 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

Review Figma :

Checkbox : https://www.figma.com/design/yKtkEY1DOl7YDvmt7jq0QF/-OUDS-Core-Lib--Review?node-id=70108-18687&t=uSmBO8R4dlXxMZ0X-1 Radio button : https://www.figma.com/design/yKtkEY1DOl7YDvmt7jq0QF/-OUDS-Core-Lib--Review?node-id=70108-18688&t=uSmBO8R4dlXxMZ0X-1 Switch : https://www.figma.com/design/yKtkEY1DOl7YDvmt7jq0QF/-OUDS-Core-Lib--Review?node-id=70108-18717&t=uSmBO8R4dlXxMZ0X-1

Pour le chekcbox et le radio button : Il y a un problème de padding inline ce qui décale la check par exemple. On le voit également en se calant sur la check et ça décale donc le text. Pour le switch : Décalage de l’icône error dans le state Error

Hello @jerome-regnier
Cette version inclus les correctifs suivants :

  1. Problème de padding inline qui décale l'indicateur (checkbox et radio button)
  2. Décalage de l'icône error pour le switch
  3. Ajout de la font family Helvetica Neue pour la version Flutter iOS uniquement

Je ne suis pas certain que cela corrige le problème de décalage de font mais on peut faire le test ⁠:)

Build Version :

(iOS) : Design Toolbox Flutter (alpha) (520)
(Android) DesignToolbox (alpha) (520)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Component Update] Checkbox v2.4.0 [Component Update] Standalone checkbox and radio button rounded corners

3 participants