feature: Localization UI Improvement#18911
feature: Localization UI Improvement#18911diegosigaran wants to merge 2 commits intoOrchardCMS:mainfrom
Conversation
…lacement.json file so I file the 'save' button in the Localization admin menu.
|
Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request. |
|
@dotnet-policy-service agree |
|
Is there anything else other than the placement? |
|
In regards to what I need help with, its only the placement. In hindsight, I realize that on the main issue thread when I posted my screen recording, I showed behavior while RazorRuntimeCompilation was set to on. With it turned off (the main branch value), the UI does not behave how I showed it. I'm going to take some more time to iron that out before marking this as ready for review, but I would appreciate if you could give me insight to why the placement doesn't work. |
I will check ..
Why? |
|
I can't recall the exact steps I took when I had issues with hot reload, but changing that setting made it work. I now understand the dotnet watcher needs to run from the root directory for it to work properly. |
|
@diegosigaran I fixed the placement, meanwhile I noticed:
|
|
Could I be removed as the assignee? I have many questions about Orchard Core and need to spend time understanding it better, before trying to contribute. I appreciate the opportunity. |
|
@diegosigaran, you did a great job. You are close to finalizing the PR. The remaining things are not related to OC, it's a javascript thinks |
For Hisham OC: I'm having difficulty figuring out how to correct my placement.json file so I hide the 'save' button in the Localization admin menu.
Fixes #18771