Skip to content

feature: Localization UI Improvement#18911

Draft
diegosigaran wants to merge 2 commits intoOrchardCMS:mainfrom
diegosigaran:localization-ui-improvement
Draft

feature: Localization UI Improvement#18911
diegosigaran wants to merge 2 commits intoOrchardCMS:mainfrom
diegosigaran:localization-ui-improvement

Conversation

@diegosigaran
Copy link
Copy Markdown

@diegosigaran diegosigaran commented Feb 27, 2026

For Hisham OC: I'm having difficulty figuring out how to correct my placement.json file so I hide the 'save' button in the Localization admin menu.

Fixes #18771

…lacement.json file so I file the 'save' button in the Localization admin menu.
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request.

@diegosigaran
Copy link
Copy Markdown
Author

@dotnet-policy-service agree

@hishamco
Copy link
Copy Markdown
Member

Is there anything else other than the placement?

@diegosigaran
Copy link
Copy Markdown
Author

diegosigaran commented Feb 28, 2026

@hishamco

In regards to what I need help with, its only the placement.

In hindsight, I realize that on the main issue thread when I posted my screen recording, I showed behavior while RazorRuntimeCompilation was set to on. With it turned off (the main branch value), the UI does not behave how I showed it.

I'm going to take some more time to iron that out before marking this as ready for review, but I would appreciate if you could give me insight to why the placement doesn't work.

@hishamco
Copy link
Copy Markdown
Member

In regards to what I need help with, its only the placement.

I will check ..

RazorRuntimeCompilation was set to on

Why?

@diegosigaran
Copy link
Copy Markdown
Author

diegosigaran commented Feb 28, 2026

I can't recall the exact steps I took when I had issues with hot reload, but changing that setting made it work.

I now understand the dotnet watcher needs to run from the root directory for it to work properly.

@hishamco
Copy link
Copy Markdown
Member

@diegosigaran I fixed the placement, meanwhile I noticed:

  • Fallback checkbox no longer persists
  • Closing the modal takes the culture addition in place, which is wrong

@diegosigaran
Copy link
Copy Markdown
Author

@hishamco

Could I be removed as the assignee? I have many questions about Orchard Core and need to spend time understanding it better, before trying to contribute. I appreciate the opportunity.

@hishamco
Copy link
Copy Markdown
Member

hishamco commented Mar 4, 2026

@diegosigaran, you did a great job. You are close to finalizing the PR.

The remaining things are not related to OC, it's a javascript thinks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve UX for adding cultures in Localization Settings

2 participants