Open
Conversation
Member
Author
|
/cc @BenedekFarkas |
This was referenced Mar 1, 2026
BenedekFarkas
requested changes
Mar 7, 2026
Member
BenedekFarkas
left a comment
BenedekFarkas
left a comment
There was a problem hiding this comment.
Navigating to /health/live throws error for me:
InvalidOperationException: Unable to resolve service for type 'OrchardCore.Sms.Azure.Models.AzureSmsOptions' while attempting to activate 'OrchardCore.Sms.Azure.HealthChecks.AzureSmsHealthCheck'.
Also please apply Sébastien's feedback from #18917 where applicable.
...dCore.Modules/OrchardCore.Sms.Azure/HealthChecks/Extensions/AzureSmsHealthCheckExtensions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/HealthChecks/Startup.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
BenedekFarkas
requested changes
Mar 16, 2026
src/OrchardCore.Modules/OrchardCore.Sms.Azure/HealthChecks/AzureSmsHealthCheck.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/HealthChecks/AzureSmsHealthCheck.cs
Outdated
Show resolved
Hide resolved
BenedekFarkas
requested changes
Mar 17, 2026
src/OrchardCore.Modules/OrchardCore.Sms.Azure/HealthChecks/AzureSmsHealthCheck.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@BenedekFarkas, same as email, unfortunately, I can't test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.