Skip to content

Fix: OpenIdClientSettingsStep does not protect the client secret and throws null reference exceptions #18313#19073

Open
mroskamp wants to merge 5 commits intoOrchardCMS:mainfrom
mroskamp:openid-recipe-step-improvements
Open

Fix: OpenIdClientSettingsStep does not protect the client secret and throws null reference exceptions #18313#19073
mroskamp wants to merge 5 commits intoOrchardCMS:mainfrom
mroskamp:openid-recipe-step-improvements

Conversation

@mroskamp
Copy link
Copy Markdown
Contributor

Fix issue where client secret was not being protected when set from OpenIdClientSettings recipe step. Fix null reference exception when Scope isn't specified in the recipe step. Fixes #18313, see #18315

@MikeAlhayek
Copy link
Copy Markdown
Member

MikeAlhayek commented Mar 27, 2026

@mroskamp Thank you for this PR. I rather not do this. Instead, I think you'll be able to so exactly what you want using the protect method I added here https://github.com/OrchardCMS/OrchardCore/pull/19075/changes

you'll be able to do something like this instead

{
   "steps": [
      "name":"OpenIdClientSettings",
      "ClientSecret": "[js protect("OpenIdClientConfiguration","your-plain-text-secret")]",
      ...
   ]
}

@Skrypt
Copy link
Copy Markdown
Contributor

Skrypt commented Mar 31, 2026

I've never been able to even have this working with AutoSetup. And I believe that this should be using the Secrets module to keep this secure when pushed to a repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenIdClientSettingsStep does not protect the client secret and throws null reference exceptions

4 participants