Fix: OpenIdClientSettingsStep does not protect the client secret and throws null reference exceptions #18313#19073
Open
mroskamp wants to merge 5 commits intoOrchardCMS:mainfrom
Open
Conversation
…lient secret. Fix null reference exception when Scope isn't specified.
…tSettingsStep.cs Co-authored-by: Mike Alhayek <mike@crestapps.com>
…y to OpenIdClientSettingsStepModel.
Member
|
@mroskamp Thank you for this PR. I rather not do this. Instead, I think you'll be able to so exactly what you want using the you'll be able to do something like this instead |
Contributor
|
I've never been able to even have this working with AutoSetup. And I believe that this should be using the Secrets module to keep this secure when pushed to a repository. |
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue where client secret was not being protected when set from OpenIdClientSettings recipe step. Fix null reference exception when Scope isn't specified in the recipe step. Fixes #18313, see #18315