Fix flaky MVC functional test by warming up the OrchardCore tenant pipeline before tests run

src/OrchardCore.Mvc.Web/OrchardCore.Mvc.Web.csproj

@@ -15,6 +15,7 @@
 
   <ItemGroup>
     <ProjectReference Include="..\OrchardCore\OrchardCore.Application.Mvc.Targets\OrchardCore.Application.Mvc.Targets.csproj" />
+    <ProjectReference Include="..\OrchardCore.Modules\OrchardCore.HealthChecks\OrchardCore.HealthChecks.csproj" />
     <ProjectReference Include="..\OrchardCore.Modules\OrchardCore.Mvc.HelloWorld\OrchardCore.Mvc.HelloWorld.csproj" />
   </ItemGroup>
 

test/OrchardCore.Tests.Functional/Helpers/NavigationHelper.cs

@@ -0,0 +1,14 @@
+using Microsoft.Playwright;
+using Xunit;
+
+namespace OrchardCore.Tests.Functional.Helpers;
+
+public static class NavigationHelper
+{
+    public static async Task GotoAndAssertOkAsync(this IPage page, string url)
+    {
+        var response = await page.GotoAsync(url);
+        Assert.NotNull(response);
+        Assert.True(response.Ok, $"Expected HTTP 200 but got {response.Status} for {response.Url}");
+    }
+}

test/OrchardCore.Tests.Functional/Helpers/OrchardTestServer.cs

@@ -94,6 +94,7 @@ public static async Task<OrchardTestServer> StartMvcAsync(string contentRoot, st
 
         builder.Services
             .AddOrchardCore()
+            .AddTenantFeatures("OrchardCore.HealthChecks")
             .AddMvc();
 
         ConfigureServices(builder, appDataPath, instanceId: null, loggerProvider);
@@ -104,7 +105,13 @@ public static async Task<OrchardTestServer> StartMvcAsync(string contentRoot, st
 
         await app.StartAsync();
 
-        return new OrchardTestServer(app, GetListeningAddress(app), loggerProvider.Collector);
+        var address = GetListeningAddress(app);
+
+        // The OrchardCore tenant pipeline initializes lazily on the first request.
+        // Warm up the app now so tests don't race against pipeline initialization.
+        await WarmUpAsync(address);
+
+        return new OrchardTestServer(app, address, loggerProvider.Collector);
     }
 
     public void AssertNoLoggedIssues()
@@ -341,6 +348,38 @@ private static string ReplaceDatabaseName(string connectionString, string newDbN
             System.Text.RegularExpressions.RegexOptions.IgnoreCase);
     }
 
+    /// <summary>
+    /// Polls the health endpoint until the app returns a successful response, ensuring the
+    /// OrchardCore tenant pipeline has finished its lazy first-request initialization
+    /// before the Playwright tests begin.
+    /// </summary>
+    private static async Task WarmUpAsync(string baseAddress, string healthPath = "/health/live", int timeoutSeconds = 30)
+    {
+        using var client = new HttpClient();
+        var deadline = DateTime.UtcNow.AddSeconds(timeoutSeconds);
+
+        while (DateTime.UtcNow < deadline)
+        {
+            try
+            {
+                var response = await client.GetAsync($"{baseAddress}{healthPath}");
+                if (response.IsSuccessStatusCode)
+                {
+                    return;
+                }
+            }
+            catch
+            {
+                // Server not yet accepting connections — keep waiting.
+            }
+
+            await Task.Delay(500);
+        }
+
+        throw new TimeoutException(
+            $"The application at '{baseAddress}' did not respond successfully at '{healthPath}' within {timeoutSeconds} seconds.");
+    }
+
     private static string GetListeningAddress(WebApplication app)
     {
         var server = app.Services.GetRequiredService<IServer>();

test/OrchardCore.Tests.Functional/Tests/Cms/AgencyTests.cs

@@ -11,7 +11,7 @@ public AgencyTests(AgencyFixture fixture) : base(fixture) { }
     public async Task DisplaysTheHomePageOfTheAgencyTheme()
     {
         var page = await Fixture.CreatePageAsync();
-        await page.GotoAsync("/");
+        await page.GotoAndAssertOkAsync("/");
         await Assertions.Expect(page.Locator("#services")).ToContainTextAsync("Lorem ipsum dolor sit amet consectetur");
         await page.CloseAsync();
     }
@@ -21,7 +21,7 @@ public async Task AgencyAdminLoginShouldWork()
     {
         var page = await Fixture.CreatePageAsync();
         await page.LoginAsync();
-        await page.GotoAsync("/Admin");
+        await page.GotoAndAssertOkAsync("/Admin");
         await Assertions.Expect(page.Locator(".menu-admin")).ToHaveAttributeAsync("id", "adminMenu");
         await page.CloseAsync();
     }

test/OrchardCore.Tests.Functional/Tests/Cms/BlogTests.cs

@@ -11,7 +11,7 @@ public BlogTests(BlogFixture fixture) : base(fixture) { }
     public async Task DisplaysTheHomePageOfTheBlogRecipe()
     {
         var page = await Fixture.CreatePageAsync();
-        await page.GotoAsync("/");
+        await page.GotoAndAssertOkAsync("/");
         await Assertions.Expect(page.Locator(".subheading")).ToContainTextAsync("This is the description of your blog");
         await page.CloseAsync();
     }
@@ -21,7 +21,7 @@ public async Task BlogAdminLoginShouldWork()
     {
         var page = await Fixture.CreatePageAsync();
         await page.LoginAsync();
-        await page.GotoAsync("/Admin");
+        await page.GotoAndAssertOkAsync("/Admin");
         await Assertions.Expect(page.Locator(".menu-admin")).ToHaveAttributeAsync("id", "adminMenu");
         await page.CloseAsync();
     }

test/OrchardCore.Tests.Functional/Tests/Cms/ComingSoonTests.cs

@@ -11,7 +11,7 @@ public ComingSoonTests(ComingSoonFixture fixture) : base(fixture) { }
     public async Task DisplaysTheHomePageOfTheComingSoonTheme()
     {
         var page = await Fixture.CreatePageAsync();
-        await page.GotoAsync("/");
+        await page.GotoAndAssertOkAsync("/");
         await Assertions.Expect(page.Locator("h1")).ToContainTextAsync("Coming Soon");
         await Assertions.Expect(page.Locator("p")).ToContainTextAsync("We're working hard to finish the development of this site.");
         await page.CloseAsync();
@@ -22,7 +22,7 @@ public async Task ComingSoonAdminLoginShouldWork()
     {
         var page = await Fixture.CreatePageAsync();
         await page.LoginAsync();
-        await page.GotoAsync("/Admin");
+        await page.GotoAndAssertOkAsync("/Admin");
         await Assertions.Expect(page.Locator(".menu-admin")).ToHaveAttributeAsync("id", "adminMenu");
         await page.CloseAsync();
     }

test/OrchardCore.Tests.Functional/Tests/Cms/HeadlessTests.cs

@@ -11,7 +11,7 @@ public HeadlessTests(HeadlessFixture fixture) : base(fixture) { }
     public async Task DisplaysTheLoginScreenForTheHeadlessTheme()
     {
         var page = await Fixture.CreatePageAsync();
-        await page.GotoAsync("/");
+        await page.GotoAndAssertOkAsync("/");
         await Assertions.Expect(page.Locator("h1")).ToContainTextAsync("Log in");
         await page.CloseAsync();
     }
@@ -21,7 +21,7 @@ public async Task HeadlessAdminLoginShouldWork()
     {
         var page = await Fixture.CreatePageAsync();
         await page.LoginAsync();
-        await page.GotoAsync("/Admin");
+        await page.GotoAndAssertOkAsync("/Admin");
         await Assertions.Expect(page.Locator(".menu-admin")).ToHaveAttributeAsync("id", "adminMenu");
         await page.CloseAsync();
     }

test/OrchardCore.Tests.Functional/Tests/Cms/MigrationsTests.cs

@@ -11,7 +11,7 @@ public MigrationsTests(MigrationsFixture fixture) : base(fixture) { }
     public async Task DisplaysTheHomePageOfTheMigrationsRecipe()
     {
         var page = await Fixture.CreatePageAsync();
-        await page.GotoAsync("/");
+        await page.GotoAndAssertOkAsync("/");
         await Assertions.Expect(page.GetByText("Testing features having database migrations")).ToBeVisibleAsync();
         await page.CloseAsync();
     }
@@ -21,7 +21,7 @@ public async Task MigrationsAdminLoginShouldWork()
     {
         var page = await Fixture.CreatePageAsync();
         await page.LoginAsync();
-        await page.GotoAsync("/Admin");
+        await page.GotoAndAssertOkAsync("/Admin");
         await Assertions.Expect(page.Locator(".menu-admin")).ToHaveAttributeAsync("id", "adminMenu");
         await page.CloseAsync();
     }

test/OrchardCore.Tests.Functional/Tests/Cms/SaasTests.cs

@@ -24,7 +24,7 @@ public ValueTask DisposeAsync()
     public async Task DisplaysTheHomePageOfTheSaasTheme()
     {
         var page = await _fixture.CreatePageAsync();
-        await page.GotoAsync($"/{_fixture.Tenant.Prefix}");
+        await page.GotoAndAssertOkAsync($"/{_fixture.Tenant.Prefix}");
         await Assertions.Expect(page.Locator("h4")).ToContainTextAsync("Welcome to Orchard Core, your site has been successfully set up.");
         await page.CloseAsync();
     }
@@ -34,7 +34,7 @@ public async Task SaasAdminLoginShouldWork()
     {
         var page = await _fixture.CreatePageAsync();
         await page.LoginAsync($"/{_fixture.Tenant.Prefix}");
-        await page.GotoAsync($"/{_fixture.Tenant.Prefix}/Admin");
+        await page.GotoAndAssertOkAsync($"/{_fixture.Tenant.Prefix}/Admin");
         await Assertions.Expect(page.Locator(".menu-admin")).ToHaveAttributeAsync("id", "adminMenu");
         await page.CloseAsync();
     }

test/OrchardCore.Tests.Functional/Tests/Mvc/MvcTests.cs

@@ -1,4 +1,5 @@
 using Microsoft.Playwright;
+using OrchardCore.Tests.Functional.Helpers;
 
 namespace OrchardCore.Tests.Functional.Tests.Mvc;
 
@@ -23,7 +24,7 @@ public ValueTask DisposeAsync()
     public async Task ShouldDisplayHelloWorld()
     {
         var page = await _fixture.CreatePageAsync();
-        await page.GotoAsync("/");
+        await page.GotoAndAssertOkAsync("/");
         await Assertions.Expect(page.Locator("body")).ToContainTextAsync("Hello World");
         await page.CloseAsync();
     }