Skip to content

fix: repair frontend ESLint errors and backend CI pipeline#1

Merged
Orsso merged 3 commits into
mainfrom
fix/frontend-lint-errors
Mar 18, 2026
Merged

fix: repair frontend ESLint errors and backend CI pipeline#1
Orsso merged 3 commits into
mainfrom
fix/frontend-lint-errors

Conversation

@Orsso

@Orsso Orsso commented Mar 18, 2026

Copy link
Copy Markdown
Owner

Summary

Frontend lint fixes

  • question-input.tsx: Stop reading submittedRef during render — derive isInteractive from props only, keep ref as callback guard (react-hooks/refs)
  • dashboard-grid.tsx: Move ref-sync assignments into useEffect (react-hooks/refs)
  • use-upload-message.ts: Replace synchronous setIdx() in effect with lazy useState initializer (react-hooks/set-state-in-effect)
  • card-editor.tsx: Simplify useEffect deps to [card], remove 2 stale eslint-disable
  • portaled-components.tsx + dashboard-grid.tsx: Remove unused eslint-disable directives

Backend CI fixes

  • Add .python-version (3.13) so uv uses the correct interpreter matching locked wheels
  • Convert [project.optional-dependencies] dev[dependency-groups] (PEP 735) with separate lint, test, and dev groups
  • Lint job uses --only-group lint — installs only ruff, no pyarrow/pandas/langchain build
  • Test job uses --group test — installs main deps + pytest
  • Regenerate uv.lock for new dependency structure

Test plan

  • npm run lint + npm run typecheck — 0 errors, 0 warnings
  • uv run --only-group lint ruff check — passes locally
  • CI pipeline: all 6 jobs pass (backend-lint, backend-test, frontend-lint, docker-backend, docker-sandbox, docker-frontend)

Adrien Reibel added 3 commits March 18, 2026 14:31
- question-input: stop reading submittedRef during render (react-hooks/refs)
- dashboard-grid: move ref assignments into useEffect (react-hooks/refs)
- use-upload-message: use lazy initializer instead of setState in effect
- card-editor: fix useEffect dependency array, remove stale eslint-disable
- portaled-components: remove unused eslint-disable comment
- ci: add explicit python-version to uv setup steps
The python-version parameter in setup-uv causes ruff to not be found.
Revert to match the working main branch configuration.
- Add .python-version (3.13) so uv uses the correct interpreter
- Convert [project.optional-dependencies] dev to [dependency-groups]
  with separate lint/test/dev groups (PEP 735)
- Backend lint job uses --only-group lint (installs only ruff,
  avoids building pyarrow/pandas/langchain entirely)
- Backend test job uses --group test (main deps + pytest)
- Regenerate uv.lock for new dependency structure
@Orsso Orsso changed the title fix: resolve all frontend ESLint errors and warnings fix: repair frontend ESLint errors and backend CI pipeline Mar 18, 2026
@Orsso
Orsso merged commit e19f391 into main Mar 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant