Fix spin C++ tests by aligning DeeSpin expectations and no-PBC atomic virial sizing#5
Closed
Fix spin C++ tests by aligning DeeSpin expectations and no-PBC atomic virial sizing#5
Conversation
Co-authored-by: OutisLi <137472077+OutisLi@users.noreply.github.com>
Copilot stopped work on behalf of
OutisLi due to an error
February 24, 2026 02:39
Copilot
AI
changed the title
[WIP] Fix unit tests while adding viral support to spin models
fix(dpmodel/spin): keep virial outputs in spin model while preserving unit-test compatibility
Feb 24, 2026
Copilot
AI
changed the title
fix(dpmodel/spin): keep virial outputs in spin model while preserving unit-test compatibility
Fix spin dpmodel virial output mapping to preserve spin virial support without breaking unit tests
Feb 24, 2026
…e checks Co-authored-by: OutisLi <137472077+OutisLi@users.noreply.github.com>
Copilot
AI
force-pushed
the
copilot/fix-unit-tests-spin-models
branch
from
February 24, 2026 09:50
036bfd5 to
526f9c8
Compare
Co-authored-by: OutisLi <137472077+OutisLi@users.noreply.github.com>
Copilot
AI
changed the title
Fix spin dpmodel virial output mapping to preserve spin virial support without breaking unit tests
Fix spin C++ tests by aligning DeeSpin expectations and no-PBC atomic virial sizing
Feb 24, 2026
OutisLi
requested changes
Feb 24, 2026
Owner
OutisLi
left a comment
There was a problem hiding this comment.
Did not pass the c++ unit test
Co-authored-by: OutisLi <137472077+OutisLi@users.noreply.github.com>
Co-authored-by: OutisLi <137472077+OutisLi@users.noreply.github.com>
Author
我已修复这次 C++ CI 失败点: |
…lues Co-authored-by: OutisLi <137472077+OutisLi@users.noreply.github.com>
Author
已继续定位并修复当前失败点:根据最新 CI 日志,失败是 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-4545and current branch💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.