Cleanup detectionOn.sh to improve performance - #8
Open
Ozzyminted wants to merge 1 commit into
Open
Conversation
Modify as follows:
1. Run `getimage` once at beginning of script, save image to /tmp
2. Launch all notification tasks (save snapshot, mqtt, email, telegram,
and user scripts) as background jobs, use same image image in all
cases for consistency
3. Wait for all background jobs to finish before deleting tempfile
In motion.conf.dist:
* Add default debug_msg_enable=false
* Fix typo: s/sendemail/send_email
Testing: Ran detectionOn.sh with all options+debugging enabled on a
Wyze Cam V2 and verified the following:
* LED triggered
* Snapshot jpg saved to sdcard
* Old snapshots removed from sdcard
* Ran few user scripts to read tempfile
* sendPictureMail.sh, mosquitto_pub.bin, and telegram ran, but I
didn't verify delivery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify as follows:
getimageonce at beginning of script, save image to /tmpand user scripts) as background jobs, use same image image in all
cases for consistency
In motion.conf.dist:
Testing: Ran detectionOn.sh with all options+debugging enabled on a
Wyze Cam V2 and verified the following:
didn't verify delivery