GS/TC: Break LookupTarget() into 3 functions.#14262
Open
TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
Open
GS/TC: Break LookupTarget() into 3 functions.#14262TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
Conversation
TJnotJT
force-pushed
the
gs-tc-cleanup-lookup-target
branch
from
242cb63 to
616f1b7
Compare
Separate draw lookup from frame lookup. Put common code in another processing function.
TJnotJT
force-pushed
the
gs-tc-cleanup-lookup-target
branch
from
616f1b7 to
6b68541
Compare
Contributor
Author
|
Refactored and simplied the call hierarchy a bit more. We already has a function named Did dump runs on both native and 2x, since the scaling helper class is more relevant to upscaling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Separate draw lookup from frame lookup. Put common code in another processing function.
Replaced a lambda + captures with a helper class, since it was being used like that.
Rationale behind Changes
There was a comment in LookupTarget() indicating this could be useful, and LookupTarget() is ~1000 lines long.
Suggested Testing Steps
Testing any game on any HW renderer. So far tested with a dump run.
Did you use AI to help find, test, or implement this issue or feature?
No.