GS/HW: Adjust shuffle predetect for only texture formats under 32bit - #14689
Merged
Conversation
JordanTheToaster
approved these changes
Jul 12, 2026
Mrlinkwii
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Only check for shuffles on textures which are 16bit or less in actual depth, not storage format.
Rationale behind Changes
Regression from #11461, I don't know why I said the texture format should be 32bits, makes no sense, a shuffle is always 16bit or less (on actual format size, rather than storage size), but there seems to be no regressions.
This caused it to errantly think it might be a shuffle on Gran Turismo 4 when generating the split time cars, meaning it had to request the RGB to be valid, which it wasn't on the texture it needed, it was only an alpha, so the lookup failed, making the alpha 0, so the cars were invisible.
Suggested Testing Steps
Test Gran Turismo 4 + variations, make sure the split time cars work.
Did you use AI to help find, test, or implement this issue or feature?
No