Core: Fix -Wsign-compare warning in R3000A Interpreter - #14693
Conversation
There was a problem hiding this comment.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
|
Yeah that's better, you will need to squash with the commit message starting with |
I'm unfamiliar with GitHub, and a web search has led me nowhere, is there a way to do this via the web interface? |
|
AFAIK no, but you could use something like GitHub desktop if you're unfamiliar with the CLI. |
|
I did it for you |
Thank you |
Description of Changes
Added explicit type casting to match 0xbfc4a000 implicit unsigned int type
Rationale behind Changes
Fixes a warning during compilation
Did you use AI to help find, test, or implement this issue or feature?
No, I just saw the warning when compiling pcsx2