Skip to content

Core: Fix -Wsign-compare warning in R3000A Interpreter - #14693

Merged
F0bes merged 1 commit into
PCSX2:masterfrom
BriellaBugs:patch-1
Jul 19, 2026
Merged

Core: Fix -Wsign-compare warning in R3000A Interpreter#14693
F0bes merged 1 commit into
PCSX2:masterfrom
BriellaBugs:patch-1

Conversation

@BriellaBugs

Copy link
Copy Markdown
Contributor
warning: comparison of integers of different signs: 's32' (aka 'int') and 'unsigned int' [-Wsign-compare]
  250 |         if(tar == 0xbfc4a000) {
      |            ~~~ ^  ~~~~~~~~~~

Description of Changes

Added explicit type casting to match 0xbfc4a000 implicit unsigned int type

Rationale behind Changes

Fixes a warning during compilation

Did you use AI to help find, test, or implement this issue or feature?

No, I just saw the warning when compiling pcsx2

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@BriellaBugs BriellaBugs changed the title Fix -Wsign-compare warning in R3000A Interpreter R3: Fix -Wsign-compare warning in R3000A Interpreter Jul 13, 2026
Comment thread pcsx2/R3000AInterpreter.cpp Outdated
@refractionpcsx2

refractionpcsx2 commented Jul 13, 2026

Copy link
Copy Markdown
Member

Yeah that's better, you will need to squash with the commit message starting with Core: instead of R3 to stop the actions being upset :D

@BriellaBugs

Copy link
Copy Markdown
Contributor Author

Yeah that's better, you will need to squash with the commit message starting with Core: instead of R3 to stop the actions being upset :D

I'm unfamiliar with GitHub, and a web search has led me nowhere, is there a way to do this via the web interface?

@BriellaBugs BriellaBugs changed the title R3: Fix -Wsign-compare warning in R3000A Interpreter Core: Fix -Wsign-compare warning in R3000A Interpreter Jul 17, 2026
@kamfretoz

Copy link
Copy Markdown
Contributor

AFAIK no, but you could use something like GitHub desktop if you're unfamiliar with the CLI.

@TellowKrinkle

Copy link
Copy Markdown
Member

I did it for you

@BriellaBugs

Copy link
Copy Markdown
Contributor Author

I did it for you

Thank you

@F0bes
F0bes merged commit 30962c8 into PCSX2:master Jul 19, 2026
16 checks passed
@Mrlinkwii Mrlinkwii added this to the Release 2.8 milestone Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants