GH Actions: do not persist credentials#198
Open
jrfnl wants to merge 1 commit into
Open
Conversation
Member
Author
|
Leaving this open until the next release. This may break the |
This comment was marked as outdated.
This comment was marked as outdated.
jrfnl
force-pushed
the
feature/ghactions-do-not-persist-credentials
branch
from
c1d1e1a to
55023b0
Compare
github-actions
Bot
added
Status: has merge conflict
and removed
Status: has merge conflict
labels
This comment was marked as outdated.
This comment was marked as outdated.
jrfnl
force-pushed
the
feature/ghactions-do-not-persist-credentials
branch
from
55023b0 to
5860fbe
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jrfnl
force-pushed
the
feature/ghactions-do-not-persist-credentials
branch
from
5860fbe to
84b1769
Compare
jrfnl
force-pushed
the
feature/ghactions-do-not-persist-credentials
branch
from
84b1769 to
4024f23
Compare
Member
Author
|
Rebased without changes to get passed imaginary merge conflict. |
> By default, using `actions/checkout` causes a credential to be persisted in the checked-out repo's `.git/config`, so that subsequent `git` operations can be authenticated. > > Subsequent steps may accidentally publicly persist `.git/config`, e.g. by including it in a publicly accessible artifact via `actions/upload-artifact`. > > However, even without this, persisting the credential in the `.git/config` is non-ideal unless actually needed. > > **Remediation** > > Unless needed for `git` operations, `actions/checkout` should be used with `persist-credentials: false`. > > If the persisted credential is needed, it should be made explicit with `persist-credentials: true`. This has now been addressed in all workflows. Refs: * https://unit42.paloaltonetworks.com/github-repo-artifacts-leak-tokens/ * https://docs.zizmor.sh/audits/#artipacked
jrfnl
force-pushed
the
feature/ghactions-do-not-persist-credentials
branch
from
4024f23 to
ec64c2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has now been addressed in all workflows.
Refs: