Skip to content

Fix chemical names not being recognized#2982

Closed
gerlero wants to merge 3 commits into
PMEAL:devfrom
gerlero:chemicals
Closed

Fix chemical names not being recognized#2982
gerlero wants to merge 3 commits into
PMEAL:devfrom
gerlero:chemicals

Conversation

@gerlero

@gerlero gerlero commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Fix the errors like ValueError: Chemical name (o2) not recognized (apparently caused by a change in how thermo handles names).

@gerlero

gerlero commented Sep 13, 2025

Copy link
Copy Markdown
Contributor Author

A bunch of the CI errors should be fixed by #2981. Unless you prefer otherwise, I'd rather we go through #2981 first and, then I can rebase this one (and also #2982 and #2983) on top of those changes.

@jgostick

Copy link
Copy Markdown
Member

I am working on a PR to add uv support, and I merged #2981 into that locally. I believe that your contributions will show up in the git history (thanks!), but I'll cancel that PR.

@gerlero

gerlero commented Sep 13, 2025

Copy link
Copy Markdown
Contributor Author

Sure, no problem for me with the commit authorship (and it'll also probably show correctly anyway).

@jgostick

Copy link
Copy Markdown
Member

This was merged into #2985, so closing this PR

@jgostick jgostick closed this Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants