Skip to content

Modularizing TRSP - #284

Open
jmlarson1 wants to merge 10 commits into
mainfrom
modularizing_trsp
Open

Modularizing TRSP#284
jmlarson1 wants to merge 10 commits into
mainfrom
modularizing_trsp

Conversation

@jmlarson1

@jmlarson1 jmlarson1 commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Moving the TRSP in pounders.py to be a stand-alone function. This will allow us to clean pounder.py a bit and allow us to test other QP/TRSP solvers.

@mmenickelly I found no difference with output from the Extensive tests before/after this change. Also no change when all tests used nf_max = 500

@jared321

  • Thoughts on moving the minq check out of pounders.py to the to the TRSP?
  • With that move, I don't want to do the minq check every TRSP call. I also didn't want global variables to mark/check if the check is okay. I believe lru_cache is the best way to have this done, but I'm not certain.
  • Thoughts on mpi4py in the Extensive tests? (I regularly add such code before running those tests. Others might want to as well, but the test is functional if mpi4py isn't available.)

@jmlarson1
jmlarson1 requested a review from jared321 April 29, 2026 16:28
@jmlarson1 jmlarson1 assigned mmenickelly and unassigned mmenickelly Apr 29, 2026
@jmlarson1
jmlarson1 requested a review from mmenickelly April 29, 2026 16:29
@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.33%. Comparing base (538a7ad) to head (e4afcc0).

Files with missing lines Patch % Lines
pounders/py/solve_trsp.py 84.61% 4 Missing ⚠️
pounders/py/pounders.py 66.66% 2 Missing ⚠️
pounders/py/pounders_concurrent.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   95.29%   95.33%   +0.04%     
==========================================
  Files         103      104       +1     
  Lines        4847     4847              
==========================================
+ Hits         4619     4621       +2     
+ Misses        228      226       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants