🗑️ chore: drop MCP server from the chart - #4
Merged
Merged
Conversation
Removes the MCP server entirely from the Helm chart, mirroring the app-side removal in PackmindHub/packmind#374. - Delete templates/deployment-mcp.yaml and templates/service-mcp.yaml - Remove the mcpServer HPA block from templates/hpa.yaml - Drop MCP_SERVICE_HOST/PORT env from the frontend deployment (no-ingress mode) - Remove the /mcp route and $mcpSvc from templates/ingress.yaml - Remove the mcp Secret from templates/secrets.yaml - Drop mcpServer labels/selectorLabels helpers and the mcpServer branch of secretEnvVars; simplify api/mcpServer backend conditionals to api-only - Remove mcpServer config and mcp secrets from values.yaml - Update README.md and the upgrade skill to drop MCP references - Bump chart version 1.17.0 -> 1.18.0 (required by ct check-version-increment) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
chart-testing's bundled yamale relies on ast.Num, removed in Python 3.12+. With python-version '3.x' the runner installed Python 3.14 and `ct lint` crashed while parsing its schema (AttributeError: module 'ast' has no attribute 'Num') before validating the chart. Pin to 3.11 to unblock CI. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Postgres/Redis PVCs emitted `storageClassName: ""` when no class was configured. An explicit empty string disables dynamic provisioning (unlike omitting the field, which selects the cluster default), so the PVCs stayed unbound and pods failed to schedule (surfaced by `ct install` on kind). Omit storageClassName entirely when neither the per-component nor the global storageClass is set, so the cluster's default StorageClass is used. Explicit per-component and global classes are unaffected. Also drops the always-true `if or X (not X)` wrapper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
MaloPromyze
marked this pull request as ready for review
July 10, 2026 10:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the MCP server entirely from the Helm chart, mirroring the app-side removal in PackmindHub/packmind#374 (part of the "Go fully open source" cleanup).
Opened as draft to validate CI (
ct lint/ct install) before marking ready.Changes
templates/deployment-mcp.yamlandtemplates/service-mcp.yamlmcpServerHPA block fromtemplates/hpa.yamlMCP_SERVICE_HOST/MCP_SERVICE_PORTenv from the frontend deployment (no-ingress mode)/mcproute and$mcpSvcfromtemplates/ingress.yamlSecretfromtemplates/secrets.yamlmcpServerlabels/selectorLabels helpers and themcpServerbranch ofsecretEnvVars; simplify the api/mcpServer backend conditionals to api-onlymcpServerconfig andmcpsecrets fromvalues.yamlREADME.mdand theupgrade-packmind-chartskill to drop MCP referencesversion1.17.0 → 1.18.0 (required byctcheck-version-increment)Validation
helm lint ./packmindpasseshelm templaterenders cleanly for default,ingress.enabled=false, and custom-hosts value sets — zero MCP resources emitted; ingress now routes only/apiand/(catch-all)🤖 Generated with Claude Code