Update 02_dqn_pong.py#82
Open
varenyamBakshi wants to merge 1 commit into
Open
Conversation
As uint8 is depreciated in later versions of pytorch, so instead use torch.bool for indexing the next_state_values. Using uint8 generates a user warning. Also actions_v tensor should be of dtype=torch.int64 to use the gather() .
Author
|
Also sir, I would like to thank you for writing such a great book. It is really helpful for me as you have beautifully combined the theoretical aspects with practical implementation. Hats off to you. |
Collaborator
|
Hi! First of all, thanks a lot for the pull request and book's feedback! I propose not to merge your change it into the |
Author
|
yeah sure sir. Thanks a lot for responding. Looking forward to contribute to your book, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As uint8 is depreciated in later versions of pytorch, so instead use torch.bool for indexing the next_state_values. Using uint8 generates a user warning. Also actions_v tensor should be of dtype=torch.int64 to use the gather() .