[CI] Improve error log grep by excluding pytest_*_error.log noise#7612
[CI] Improve error log grep by excluding pytest_*_error.log noise#7612EmmonsCurse wants to merge 1 commit intoPaddlePaddle:release/2.5from
Conversation
|
Thanks for your contribution! |
|
/skip-ci ci_iluvatar |
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 AI Code Review |
2026-04-24 17:18:47
📋 Review 摘要
PR 概述:在 CI 脚本中通过 --exclude 参数过滤 pytest_*_error.log 文件,降低 grep 错误日志时的噪音干扰
变更范围:CI 脚本(scripts/run_gpu_4cards.sh、scripts/run_pre_ce.sh)
影响面 Tag:CI
📝 PR 规范检查
本 PR 目标分支为 release/2.5(非 develop),根据规范,此类 PR 应为从 develop 分支 cherry-pick 而来,标题需加 [Cherry-Pick] 前缀并附上对应 develop 分支的原 PR 编号。
标题建议(可直接复制):
[Cherry-Pick][CI] Improve error log grep by excluding pytest_*_error.log noise (#XXXX)
请将
#XXXX替换为对应 develop 分支合入的原 PR 编号。
此外,PR 描述 Modifications 中提到:
"Added a log prefix message for clarity:
echo ">>> grep error in ${log_dir}""
但查看两个文件的 diff,该 echo 语句均以上下文行(无 + 前缀)出现,说明该行在本次 PR 之前已存在,本次 PR 并未新增该语句。建议修正描述,避免误导 reviewer。
问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🟡 建议 | PR 标题 | 目标分支为 release/2.5,缺少 [Cherry-Pick] 前缀和原 PR 编号 |
| ❓ 疑问 | PR 描述 | Modifications 中称新增了 echo 日志前缀,但 diff 显示该行早已存在,描述有误 |
总体评价
代码变更本身简洁合理,--exclude="pytest_*_error.log" 在 GNU grep 递归模式下语义正确,能有效过滤 pytest 生成的冗余错误日志文件,改善 CI 日志信噪比。需关注 PR 规范(补充 Cherry-Pick 标签与原 PR 编号)以及修正描述的准确性。
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/2.5 #7612 +/- ##
==============================================
Coverage ? 68.92%
==============================================
Files ? 390
Lines ? 54476
Branches ? 8595
==============================================
Hits ? 37545
Misses ? 14228
Partials ? 2703
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation
The original log scanning command captures all files containing "error", including
pytest_*_error.log, which often introduces duplicated or noisy results. This makes it harder to identify the actual root cause from CI logs.To improve signal-to-noise ratio and make log inspection more efficient, these redundant files should be excluded.
Modifications
echo ">>> grep error in ${log_dir}"--exclude="pytest_*_error.log"Usage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.