Skip to content

[BugFix] Fix legacy logger propagation leaking unformatted logs to stderr #7617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gongweibao wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −5
Open

[BugFix] Fix legacy logger propagation leaking unformatted logs to stderr #7617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions fastdeploy/logger/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,7 @@ def get_trace_logger(self, name, file_name, without_formater=False, print_to_con
logger.addHandler(console_handler)
console_handler.propagate = False
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里对 console_handler 设置 propagate 没有实际效果：propagate 是 logging.Logger 的属性，不是 logging.Handler 的属性。该行会让人误以为 handler 能控制传播，建议删除该行，统一由 logger.propagate = False 控制。

Suggested change
console_handler.propagate = False

Copilot uses AI. Check for mistakes.

# Set propagate (maintain original logic)
# logger.propagate = False
logger.propagate = False

return logger

Expand Down Expand Up @@ -311,8 +310,7 @@ def _get_legacy_logger(self, name, file_name, without_formater=False, print_to_c
logger.addHandler(console_handler)
console_handler.propagate = False
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里对 console_handler 设置 propagate 没有实际效果：propagate 是 logging.Logger 的属性，不是 logging.Handler 的属性。建议删除该行，避免误导，统一由 logger.propagate = False 控制。

Suggested change
console_handler.propagate = False

Copilot uses AI. Check for mistakes.

# Set propagate (maintain original logic)
# logger.propagate = False
logger.propagate = False

return logger

Expand Down
2 changes: 1 addition & 1 deletion tests/logger/test_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def test_legacy_logger_creation(self):
def test_logger_propagate(self):
"""Test log propagation settings"""
legacy_logger = self.logger._get_legacy_logger("test", "test.log")
self.assertTrue(legacy_logger.propagate)
self.assertFalse(legacy_logger.propagate)
Copy link
Copy Markdown

@PaddlePaddle-bot PaddlePaddle-bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 建议 get_trace_logger() 缺少 propagate 测试覆盖

本次 PR 同时修复了 get_trace_logger() 和 _get_legacy_logger() 中的 propagate 设置，但测试用例 test_logger_propagate 仅验证了 _get_legacy_logger() 的行为，get_trace_logger() 缺少对应断言。

建议补充：

def test_logger_propagate(self):
    """Test log propagation settings"""
    legacy_logger = self.logger._get_legacy_logger("test", "test.log")
    self.assertFalse(legacy_logger.propagate)
    # Also verify get_trace_logger
    trace_logger = self.logger.get_trace_logger("test_trace", "test_trace.log")
    self.assertFalse(trace_logger.propagate)


def test_get_trace_logger_basic(self):
"""Test basic functionality of get_trace_logger"""
Expand Down
Loading