Skip to content
This repository was archived by the owner on Mar 16, 2023. It is now read-only.

Look for correct version in list of possible versions - #363

Open
dreilly1982 wants to merge 2 commits into
PaloAltoNetworks:developfrom
dreilly1982:feature/fix-337
Open

Look for correct version in list of possible versions#363
dreilly1982 wants to merge 2 commits into
PaloAltoNetworks:developfrom
dreilly1982:feature/fix-337

Conversation

@dreilly1982

@dreilly1982 dreilly1982 commented Feb 17, 2020

Copy link
Copy Markdown

Look for correct version in list of possible versions

Description

Changed logic in minemeld.ft.taxii.py to look for appropriate version in a list of available versions as opposed to comparing first version in list to what we want.

Motivation and Context

fixes #337

How Has This Been Tested?

I have used this change in a custom written extension based on this miner.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • [N/A] I have updated the documentation accordingly.
  • [N/A] I have read the CONTRIBUTING document.
  • [N/A] I have added tests to cover my changes if appropriate.
  • [N/A ] All new and existing tests passed.

I accept all terms of the Apache License version 2.0

@jtschichold

Copy link
Copy Markdown
Member

Thanks! Could you state that you accept the Apache license?

@dreilly1982

Copy link
Copy Markdown
Author

I accept all terms of the Apache License version 2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants