Draft
refactor(curves)!: replace flo-curves with kurbo#202
flo-curves with kurbo#202Conversation
Copilot created this pull request from a session on behalf of
rami3l
August 1, 2026 18:25
View session
rami3l
force-pushed
the
copilot/migrate-monoxide-curves-to-kurbo
branch
2 times, most recently
from
August 1, 2026 18:56
15d3c31 to
a978dfe
Compare
rami3l
reviewed
Aug 1, 2026
|
|
||
| /// A quadratic bezier segment, with `P` as the point type | ||
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct QuadSegment<P> { |
Collaborator
There was a problem hiding this comment.
Not sure if it's still worth it to keep CubeSegment generic. It looks like QuadSegment is actually generic in the codebase but not for CubeSegment. Maybe a default generic param =Point2D can be used?
Collaborator
There was a problem hiding this comment.
lgtm, I'll try to let my agent add a =point2d
Collaborator
There was a problem hiding this comment.
@lynzrand BTW do you think CubeSegment needs to be generic? Because our agent decided that it's actually always materialized with Point2D and has thus removed that param.
rami3l
force-pushed
the
copilot/migrate-monoxide-curves-to-kurbo
branch
from
August 1, 2026 19:17
a978dfe to
e4594e9
Compare
flo-curves with kurbo
Co-authored-by: rami3l <rami3l@outlook.com>
rami3l
force-pushed
the
copilot/migrate-monoxide-curves-to-kurbo
branch
from
August 1, 2026 19:18
e4594e9 to
496d58e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #203.
monoxide-curvespreviously re-implementedflo_curves' generic point/curve traits by hand. This replaces that layer withkurbo, keeping only the custom stroked-with-alignment logic thatkurbodoesn't provide.Core types now wrap kurbo directly
Point2D= re-export ofkurbo::Point;Affine2D= re-export ofkurbo::Affine.unit_x,translated,mirrored_along,flips_direction, etc.) added viaPoint2DExt/AffineExtextension traits instead of a full custom type.CubicSegment/CubicBezier/builder/iterator rewritten as concrete (non-generic) types backed bykurbo::CubicBez/Line/PathSeg, dropping the genericPoint/Numtrait scaffolding.Dropped hand-rolled algorithms in favor of kurbo
cube_to_quadnow delegates tokurbo::CubicBez::to_quads, removing ~250 lines of custom FontForge/naive conversion code.kurbo::ParamCurveArclen::arcleninstead of a customflo_curves-based implementation.cube/compat.rsand other pureflo_curvescompatibility scaffolding removed.Stroked-with-alignment logic preserved
kurbo::Vec2.Consumer crates (
monoxide-script,monoxide-font,monoxide-playground) were updated to drop the now-unnecessary generic parameters and pull in the new extension traits where needed.monoxide-ttfis unaffected, since itsQuadBezier<(fword, fword)>usage relies onQuadBezierremaining generic, which is retained.