Consolidate methods and standardize units for calculating saturated vapor pressure deficit - #3597
Merged
dlebauer merged 7 commits intoAug 15, 2025
Merged
Conversation
14 tasks
infotroph
approved these changes
Aug 15, 2025
infotroph
left a comment
Member
There was a problem hiding this comment.
Needs Roxygen run and I see one logger call that will never fire, but otherwise looks good
Comment on lines
+139
to
+142
| PEcAn.logger::logger.severe( | ||
| method, | ||
| "for converting temperature to saturated vapor pressure not supported" | ||
| ) |
Member
There was a problem hiding this comment.
FTR match.arg will handle this case for you by erroring on no match, so this logger call will never fire.
Merged
via the queue into
PecanProject:develop
with commit Aug 15, 2025
7e959cb
16 of 25 checks passed
infotroph
pushed a commit
to infotroph/pecan
that referenced
this pull request
Aug 16, 2025
…essure Quick update to PecanProject#3597: export and document t2es alias; add venv/ to .Rbuildignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consolidate get.es, SatVapPres functions and a new method proposed in #3590 into a single saturated_vapor_pressure function with args
❓ is there a preferred method to use as default?
Review Time Estimate
Types of changes
Checklist: