read LAI from sipnet.out if present - #4090
Merged
Merged
Conversation
mdietze
approved these changes
Sep 2, 2026
mdietze
left a comment
mdietze
left a comment
Member
There was a problem hiding this comment.
side note before you close the associated issue -- would be good to check read/write.restart.SIPNET as having LAI likely simplifies the logic there. The LAI vs leafC inconsistency on read/write has been a pain for ~14 years and I regret not modifying SIPNET v1 way back then.
mdietze
enabled auto-merge
September 2, 2026 14:32
Merged
via the queue into
PecanProject:develop
with commit Sep 2, 2026
0e81fe2
31 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4089: Checks for an
LAIcolumn in sipnet.out and uses it if present; otherwise calculates it from leaf carbon content and leaf specific weight as previously done.Will not change any model runs until PecanProject/sipnet#393 is implemented, but no need to wait for that before merging this.