[qref 3.2] Migrate gate-like ops' plxpr conversion to reference semantics#2672
Open
paul0403 wants to merge 13 commits intopaul0403/qref_frontend_alloc_and_obsfrom
Open
[qref 3.2] Migrate gate-like ops' plxpr conversion to reference semantics#2672paul0403 wants to merge 13 commits intopaul0403/qref_frontend_alloc_and_obsfrom
paul0403 wants to merge 13 commits intopaul0403/qref_frontend_alloc_and_obsfrom
Conversation
paul0403
commented
Apr 13, 2026
Comment on lines
+180
to
+190
| for w in op.wires: | ||
| if isinstance(w, DynamicJaxprTracer) and isinstance(w.val.aval, QrefQubit): | ||
| in_qubits.append(w) | ||
| else: | ||
| in_qubits.append(qref_get_p.bind(self.init_qreg, w)) | ||
| for w in control_wires: | ||
| if isinstance(w, DynamicJaxprTracer) and isinstance(w.val.aval, QrefQubit): | ||
| in_control_qubits.append(w) | ||
| else: | ||
| in_control_qubits.append(qref_get_p.bind(self.init_qreg, w)) | ||
|
|
Member
Author
There was a problem hiding this comment.
TODO: do this treatement for everyone
Contributor
|
Hello. You may have forgotten to update the changelog!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Migrate gate-like ops' plxpr conversion to reference semantics.
This PR also handles dynamic allocations and deallocations from
qml.allocate().Note: adjointed gates are not handled in this PR. They will be handled in a future PR that specifically handles the adjoint region from plxpr.
Related GitHub Issues:
[sc-115869]