KMIP Defaults changes. Support more than 1 KMIP Provider executions#115
Open
saikumar-vs wants to merge 6 commits intomasterfrom
Open
KMIP Defaults changes. Support more than 1 KMIP Provider executions#115saikumar-vs wants to merge 6 commits intomasterfrom
saikumar-vs wants to merge 6 commits intomasterfrom
Conversation
saikumar-vs
requested review from
ParveezBaig,
hrvojem,
mchawla16 and
vinperothas
ParveezBaig
reviewed
Jan 12, 2026
…ess-run.sh - Address review comment to reduce duplicate code - Renamed `cleanup_existing_container` to `stop_kmip_container` for clarity. - Improved logging for stopping active KMIP containers. - Added checks for sudo access before writing configuration files. - Enhanced port validation to check for TIME_WAIT state. - Streamlined error handling in various functions to return errors instead of exiting. - Updated data directory copying logic to use original WORKDIR for templates. - Cleaned up RUNDIRs after all trials are complete, ensuring proper resource management.
…ation in savetrial function and ensure WORKDIR and log subdirectory are created as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent PR: https://github.com/Percona-QA/percona-qa/pull/415/files
How to test, set configs to:
COMPONENT_KEYRING_FILE=0
COMPONENT_KEYRING_KMIP=1